Fix localization in Brave web-ui pages and Brave strings in general #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
++. Yep, I'm not sure will it work like that on Android or not. |
simonhong
reviewed
Nov 8, 2018
| @@ -6,6 +6,62 @@ | |||
| <emit emit_type='prepend'></emit> | |||
| </output> | |||
| <output filename="brave_generated_resources.pak" type="data_package" /> | |||
There was a problem hiding this comment.
Should we generate brave_generated_resources.pak?
There was a problem hiding this comment.
yes, it's needed for the includes, otherwise, the includes for google tag manager polyfill and google services fails to load.
simonhong
approved these changes
Nov 8, 2018
|
Hmm, I also tried to make |
bbondy
added a commit
that referenced
this pull request
Nov 8, 2018
Fix localization in Brave web-ui pages and Brave strings in general
bbondy
added a commit
that referenced
this pull request
Nov 8, 2018
Fix localization in Brave web-ui pages and Brave strings in general
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR localization would not show up for our own custom strings.
I tried making our own version of brave_repack_locales to avoid the patch but it gave some errors about things like "fr.pak" already exists. It seemed not easy to resolve so went with this since it was working and pretty lite on patching.
Fix brave/brave-browser#2035
After this lands I think I'll need a bit more to get it to work on Android, I'll do a PR for Android separate.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: