Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset sync warning message needs to be Refactored #2253

Closed
GeetaSarvadnya opened this issue Nov 27, 2018 · 1 comment · Fixed by brave/brave-core#1019
Closed

Reset sync warning message needs to be Refactored #2253

GeetaSarvadnya opened this issue Nov 27, 2018 · 1 comment · Fixed by brave/brave-core#1019
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 27, 2018

Description

Reset sync warning message needs to be Refactored

Steps to Reproduce

  1. Current reset sync message doesn't have information like Reset sync clears the data which is stored on the sync server
    image

Actual result:

image

Expected result:

Reset sync message needs to be refactored

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

#2134

@GeetaSarvadnya GeetaSarvadnya added this to the 1.x Backlog milestone Nov 27, 2018
@GeetaSarvadnya GeetaSarvadnya added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Nov 27, 2018
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 12, 2018
@rebron rebron modified the milestones: 1.x Backlog, 0.58.x - Release Dec 12, 2018
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Dec 14, 2018

Verification passed on

Brave 0.59.8 Chromium: 71.0.3578.98 (Official Build) beta (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows

image

Verified passed with

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification PASSED on Ubuntu 18.04.1 x64 using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

screen shot 2018-12-18 at 12 03 21 am

screen shot 2018-12-18 at 12 04 08 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants