Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use media publisher name and favicon in site banner #1924

Closed
NejcZdovc opened this issue Oct 31, 2018 · 5 comments · Fixed by brave/brave-core#800
Closed

Use media publisher name and favicon in site banner #1924

NejcZdovc opened this issue Oct 31, 2018 · 5 comments · Fixed by brave/brave-core#800

Comments

@NejcZdovc
Copy link
Contributor

Description

We need to show media publisher name and favicon in site banner circle if publisher don't provide custom image. We should do the same for regular sites regarding favicon. We need to pass name and favicon into webui. If publisher is media we should pass publisher name, if regular site we should pass in domain as name.

Steps to Reproduce

  1. enable rewards
  2. go to https://www.youtube.com/channel/UCFNTTISby1c_H-rm5Ww5rZg
  3. click on bat logo and click donate

Actual result:

image

Expected result:

image

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@mandar-brave
Copy link

Requesting uplift to 0.57 Beta.

@kjozwiak
Copy link
Member

Requesting uplift to 0.57 Beta.

Thanks @mandar-brave, just a heads up for the future, uplift labels should be used on the PR's associated with the issue and not the issue itself.

@NejcZdovc NejcZdovc changed the title Media publishers site banner Use media publisher name and favicon in site banner Nov 19, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.58.x - Dev, 0.57.x - Beta Nov 20, 2018
@LaurenWags
Copy link
Member

@NejcZdovc it's expected that we don't add 'on YouTube' on the site banner, correct? Just wondering as we do have this 'on YouTube' text on the panel and brave://rewards page (see below).
screen shot 2018-11-26 at 4 12 37 pm
screen shot 2018-11-26 at 4 12 46 pm

Here's the site banner for comparison:
screen shot 2018-11-26 at 4 12 57 pm

@LaurenWags
Copy link
Member

Per discussion with @NejcZdovc logged #2238 for the missing 'on YouTube' text on site banner.

@LaurenWags
Copy link
Member

LaurenWags commented Nov 26, 2018

Verified passed with

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Mac OS X

Verification Passed on

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Windows

Verification passed on

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants