Add support for YouTube in the Rewards panel

[NejcZdovc]

Description

Steps to Reproduce

1. go to youtube video
2. open panel

Actual result:

we display youtube as publisher

Expected result:

we should display an actual publisher on the youtube and not youtube

Reproduces how often:

Brave version (chrome://version info)

Reproducible on current release:

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

[LaurenWags]

Verified passed with

Brave	0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Mac OS X

• Verified with test plan from Youtube media publishers now appear properly in Rewards panel brave-core#699
• Encountered Cannot tip directly to Twitch channels. #1814 when tried to test for Twitch
• Encountered Use media publisher name and favicon in site banner #1924 when checking this issue as well

Verification Passed on

Brave	0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Linux

• Verified with test plan from Youtube media publishers now appear properly in Rewards panel brave-core#699

Verification Passed on

Brave	0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Windows

• Verified with test plan from Youtube media publishers now appear properly in Rewards panel brave-core#699

[kjozwiak]

@brave/legacy_qa have we worked with @evq to make sure that tips are actually going to the specified content creator on YT rather than YT itself?

@NejcZdovc I changed the title as Twitch still doesn't seem to be working as per #1814. Please change it back if you feel differently.

@davidtemkin are we okay with Twitch not working for the 0.56.x release or should we consider #1814 as a blocker?

[davidtemkin]

@kjozwiak Twitch has been separated out -- I didn't think this was on the table for .56. Going live with YT sooner is still a big improvement regardless.

[kjozwiak]

@kjozwiak Twitch has been separated out -- I didn't think this was on the table for .56. Going live with YT sooner is still a big improvement regardless.

Thanks @davidtemkin! Agreed, having YT working is a big improvement. Just wanted to double check and make sure we were on the same page so there's no surprises once 0.56.x goes out the door 👍

[jnki]

i have just updated to Version 0.56.12 Chromium: 70.0.3538.77 (Official Build) (64-bit)

there is still no way to tip directly to publisher for me.

this is all that shows up in the panel:

[NejcZdovc]

@jnki on which url?

[kjozwiak]

@jnki as @NejcZdovc mentioned, providing a URL would be super helpful so we can check and see if we can reproduce what you're seeing.

Are you seeing this on every YT channel? Does the same issue happen when you try it again in a new tab or window?

[jnki]

If I go to youtube.com, the panel looks like this:

If I go to any youtube video, or a any youtube channel, the panel looks like this:

[kjozwiak]

@jnki is Brave Rewards disabled by any chance? If you visit brave://rewards, is the switch Off?

If it's Off, you'll need to enable Rewards and you should start seeing the channels listed under the Brave Rewards panel.

[jnki]

Yup, it is already enabled

[kjozwiak]

Yup, it is already enabled

Is auto-contribution disabled under brave://rewards? If you enable it, can you see channels appearing under the Rewards panel?

[jnki]

Auto contribution is enabled, all the sites i've visited visited since the previous build are still there, and new sites are appearing too.
(however, i cannot exclude any of those sites... but that's a whole other issue).

[jnki]

i backed up my user profile and tried with a new one.
everything seems to work fine with the clean profile.

any chance i could get it to work on my current profile? i'd hate to lose all my settings