Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube media publishers now appear properly in Rewards panel #699

Merged
merged 5 commits into from
Oct 29, 2018
Merged

Youtube media publishers now appear properly in Rewards panel #699

merged 5 commits into from
Oct 29, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Oct 19, 2018 •
edited by NejcZdovc
Loading

Resolves: brave/brave-browser#1282

Ledger implementation: brave-intl/bat-native-ledger#151
UI implementation: brave/brave-ui#225

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Start Brave with clean profile and enable Rewards
  2. View Youtube video for required amount of time.
  3. Tab to or open Rewards page and ensure Youtube publisher is added to auto-contribute table.
  4. Tab or switch back to youtube video and open Rewards panel
  5. Ensure that Youtube channel publisher and icon show instead of Youtube.
  1. Start Brave with clean profile and enable Rewards
  2. View Youtube live stream for required amount of time.
  3. Tab to or open Rewards page and ensure Youtube publisher is added to auto-contribute table.
  4. Tab or switch back to youtube live stream and open Rewards panel
  5. Ensure that Youtube channel publisher and icon show instead of Youtube.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler jasonrsadler self-assigned this Oct 19, 2018
@jasonrsadler
Copy link
Contributor Author

jasonrsadler commented Oct 19, 2018 •
edited
Loading

Blocked on pending review of brave-intl/bat-native-ledger#151 and brave/brave-ui#225

@jasonrsadler jasonrsadler mentioned this pull request Oct 24, 2018
Merged
@NejcZdovc NejcZdovc removed their request for review October 24, 2018 09:06
NejcZdovc
NejcZdovc reviewed Oct 25, 2018
View reviewed changes
components/brave_rewards/browser/publisher_info_database.cc Outdated
"mpi.publisher_id = ai.publisher_id "
"WHERE mpi.media_key=?"));
std::string sql_str;
if (use_as_publisher_key) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of regular publisher load, so we should just call that function if we need to

Copy link
Contributor Author

@jasonrsadler jasonrsadler Oct 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing should change from regular publisher load as use_media_key is an optional parameter. Should it still be split out to separate?
Ok. I misunderstood. Will fix.

@jasonrsadler jasonrsadler changed the title Youtube and Twitch media publishers now appear properly in Rewards panel Youtube media publishers now appear properly in Rewards panel Oct 25, 2018
@jasonrsadler jasonrsadler reopened this Oct 25, 2018
@NejcZdovc NejcZdovc self-requested a review October 26, 2018 04:46
@NejcZdovc NejcZdovc self-assigned this Oct 29, 2018
@NejcZdovc NejcZdovc mentioned this pull request Oct 29, 2018
Closed
Jason Sadler and others added 5 commits October 29, 2018 21:38
@NejcZdovc
Fixes brave/brave-browser#1282
6a26df2 
Updated logic for specifying favicon

update for youtube showing right away in panel.

Stabilized youtube media publisher panel

Cleaning up debug lines

Cleaned up redundant database functionality

Removed unused logic
@NejcZdovc
Fixes double on provider
4456afd
@NejcZdovc
Fixes path for visit
585c0db
@NejcZdovc
Adds missing pub info to media publishers
f18990b
@NejcZdovc
Updates DEP
eb501d9
@jasonrsadler
Copy link
Contributor Author

Created follow up for youtube custom path publishers: brave/brave-browser#1886

jasonrsadler
jasonrsadler commented Oct 29, 2018
View reviewed changes
Copy link
Contributor Author

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 7f686e1 into brave:master Oct 29, 2018
NejcZdovc added a commit that referenced this pull request Oct 29, 2018
@NejcZdovc
Merge pull request #699 from jasonrsadler/pub_media_panel_core
f4fa67e 
Youtube media publishers now appear properly in Rewards panel
NejcZdovc added a commit that referenced this pull request Oct 29, 2018
@NejcZdovc
Merge pull request #699 from jasonrsadler/pub_media_panel_core
2dcd0e7 
Youtube media publishers now appear properly in Rewards panel
@NejcZdovc
Copy link
Contributor

master 7f686e1
0.57.x f4fa67e
0.56.x 2dcd0e7

@LaurenWags LaurenWags mentioned this pull request Nov 2, 2018
Closed
@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
@jasonrsadler jasonrsadler deleted the pub_media_panel_core branch June 1, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

Assignees

@NejcZdovc NejcZdovc

@jasonrsadler jasonrsadler

Labels
feature/rewards
Projects
None yet
Milestone
0.56.x - Release
Development

Successfully merging this pull request may close these issues.

Add support for YouTube in the Rewards panel
3 participants
@jasonrsadler @NejcZdovc @bbondy