Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical tabs' titles glyphs show after being drag and dropped in floating mode #29668

Closed
stephendonner opened this issue Apr 13, 2023 · 3 comments · Fixed by brave/brave-core#18100

Comments

@stephendonner
Copy link

stephendonner commented Apr 13, 2023

Description

Vertical tabs' titles glyphs show after being drag and dropped in floating mode

Found while testing #29692

Steps to Reproduce

  1. install 1.52.37
  2. launch Brave
  3. set Use vertical tabs to Enabled via brave://flags
  4. load a few sites
  5. context-click any tab
  6. choose Use Vertical Tabs
  7. with Float on mouseover checked, ensure the tab strip is collapsed
  8. drag any site (via its favicon) out into its own window
  9. drag and drop it back into the tab strip
  10. notice the tab strip

Actual result:

Tab strip now has textual artifacts/glyphs from the tab's title

example, in context extra text showing
image (2) image (3)

Expected result:

No such artifacts

image

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.52.37 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2846)

Miscellaneous Information:

/cc @sangwoo108 @rebron @brave/qa-team

@srirambv
Copy link
Contributor

srirambv commented Apr 14, 2023

This happens on collapsed view as well and on the teared out window as well. Reported in a duplicate issue here

image

@kjozwiak
Copy link
Member

The above requires 1.51.97 or higher for 1.51.x verification 👍

@stephendonner
Copy link
Author

stephendonner commented Apr 20, 2023

Verification PASSED using

Brave 1.51.97 Chromium: 112.0.5615.138 (Official Build) beta (64-bit)
Revision 2258f2fcaeb07bc95c992b7ca47f0b43ead9865c-refs/branch-heads/5615@{#1282}
OS Windows 10 Version 22H2 (Build 19045.2846)

Steps:

Followed my original steps to reproduce; note that I did have issues re-attaching a window back to the tab strip; I'll investigate, but it's separate from this issue and verification

Confirmed dragging out and dropping back in correctly placed the tab in its drop-target position, without leaving glyphs of the tab titles from the various float/expanded/minimized modes

issue29668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment