Wrong page is shown in rewards panel when on YT

[btlechowski]

Description

Steps to Reproduce

1. Clean profile
2. Enable rewards and claim grant
3. Open google.com in new tab and wait till Send a tip is shown in rewards panel (reload if needed)
4. Open youtube.com in another tab and wait till Send a tip is shown in rewards panel
5. Switch to google.com tab and show rewards panel
6. Switch to youtube.com tab and open a video
7. Quickly switch back to google tab and wait for youtube page to load
8. Switch to youtube tab and open rewards panel

Actual result:

Wrong page(google.com instead of youtube.com) is shown in rewards panel.
The page shown in the rewards panel will be used for tipping(google.com instead of youtube.com)
Reloading the page will not fix the issue.

Recording starts at step 5.

Expected result:

The proper page is shown in rewards panel

Reproduces how often:

always

Brave version (brave://version info)

Verification passed on

Brave	0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Windows 7 x64

cc @kjozwiak @LaurenWags @srirambv @GeetaSarvadnya @mandar-brave @NejcZdovc

[LaurenWags]

Reproduced on macOS

Brave	0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Mac OS X

[NejcZdovc]

@LaurenWags @btlechowski this will be fixed with this one #1517

[kjozwiak]

As per @NejcZdovc, this will be fixed by #1517 which is inside the 1.x Backlog. Moved this issue into the same milestone.

[NejcZdovc]

closing as dupe, because it has the same problem then #1517

[btlechowski]

Reproduced in 0.55.20 on Ubuntu 17.10. #1517 did not fix the issue.

Brave	0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Linux

[kjozwiak]

Here's STR that I've been using to reproduce the above:

• launch 0.55.20 Chromium: 70.0.3538.67 using a brand new profile
• visit https://www.youtube.com/channel/UCCatR7nWbYrkVXdxXb4cGXw
• click on the BAT icon in the URL and click on Join Rewards
• once the wallet has been created, open a new tab and load brave.com
• click on the BAT icon in the URL and you should see brave.com
• switch back to the YT tab (Datadash) and click on the BAT icon in the URL

You'll get the following:

[NejcZdovc]

So I did a fix where when we switch tabs we don't preserve tabs. So now the expected behaviour is that when you switch back to https://www.youtube.com/channel/UCCatR7nWbYrkVXdxXb4cGXw tab panel should show wallet summary. This will be fully fixed when we add support for media publishers in #1282

[GeetaSarvadnya]

Tried above 2 STR's, issue is fixed and working fine on:

Brave	0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Windows

Verified passed with

Brave	0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Mac OS X

• Verified STR from description and steps from Wrong page is shown in rewards panel when on YT #1660 (comment).

Verification Passed on

Brave	0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Linux