Cannot tip directly to Twitch channels.

[jnki]

Description

When you visit a verified twitch channel and attempt to "send tip", it only lets you send a tip to twitch.tv, not the specific channel.

Steps to Reproduce

1. Visit a brave verified twitch channel (mine as example)
2. Click on Brave Rewards button

Actual result:

Expected result:

Expect to see correct url for the specific twitch channel with verified badge, and be able to send tip to it.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision | 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS | Windows 10 64bit 1809

[NejcZdovc]

thank you for your report. Will close this one as we will add support for twitch in with this one #1282

[mandar-brave]

@NejcZdovc reopening as #1282 did not solve for Twitch

[LaurenWags]

Verified passed with

Brave	0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Mac OS X

• Verified test plan from Panel, tipping, and favicon should now be working correctly for twitch publishers brave-core#888
• Verified STR
• Encountered twitch tipping scenarios not currently considered #3327, generic twitch favicon displayed for verified twitch publisher #3330, twitch verified pubs name is empty in Thank you - Rewards Banner #3265
• Verified that unverified publishers show generic twitch icon in Auto-Contribute table, Tips table, and Panel.
  
  
• Verified that unverified publishers do not show favicon on tipping banner
  
• Verified that verified publishers show their favicon in Auto-Contribute table, Tips table, and Panel (except for scenario outlined in generic twitch favicon displayed for verified twitch publisher #3330)
  
  
• Verified that verified publishers do show a favicon on tipping banner
  
• Verified that custom tipping banner shows for verified twitch publishers:
  

Verification passed on

Brave	0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Linux

• Used test plan from Panel, tipping, and favicon should now be working correctly for twitch publishers brave-core#888
• Used STR from the OP

Verified that:

• unverified publishers show generic twitch icon in Auto-Contribute table, Tips table, and Rewards Panel.
• verified publishers show their favicon in Auto-Contribute table, Tips table and Rewards Panel
• unverified publishers show generic icon and banner on tipping banner
• verified publishers show custom icon and banner on tipping banner

Encountered #3330 (comment)

Verification passed on

Brave	0.60.27 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Windows 10

• Verified test plan from Panel, tipping, and favicon should now be working correctly for twitch publishers brave-core#888
• Encountered generic twitch favicon displayed for verified twitch publisher #3330, twitch verified pubs name is empty in Thank you - Rewards Banner #3265

• Verified that unverified publishers show generic twitch icon in Auto-Contribute table, Tips table, and Panel.
  
  

• Verified that unverified publishers do not show favicon on tipping banner
  

• Verified that verified publishers show their favicon in Auto-Contribute table, Tips table, and Panel
  
  

• Verified that verified publishers do show a favicon on tipping banner