Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Tab Pane Issue #32282

Open
GreyKaizen opened this issue Aug 16, 2023 · 6 comments
Open

Vertical Tab Pane Issue #32282

GreyKaizen opened this issue Aug 16, 2023 · 6 comments
Assignees

Comments

@GreyKaizen
Copy link

Description

Vertical tabs are misbehaving, when the vertical tab pane is collapsed i can only see favicons of few websites even though i have alot of tabs opens, the vertical tab pane is split in half

Steps to Reproduce

Open Bunch of tabs and enable vertical tabs then use it for a while and it start to split in weird ways

Actual result:

in this screen shot below, i have opened about 15 tabs but i can only see 5 tabs and rest are scrollable, and sometime the scroll gets stuck too i can't access the top most tab in vertical tab pane

Screenshot 2023-08-16 104316

Expected result:

Pretty much like the way Microsoft Edge vertical tabs are working

Reproduces how often:

Each time i hover over the Vertical Tab Pane the issue constantly occurs

Brave version (brave://version info)

Brave 1.56.20 Chromium: 115.0.5790.171 (Official Build) (64-bit)
Revision cf9067bf10d8f798c24643029af1d24e275646d6-refs/branch-heads/5790@{#1924}
OS Windows 11 Version 22H2 (Build 22621.2134)

Version/Channel Information:

Don't Know

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

No Additional Information.
@GreyKaizen
Copy link
Author

Enabled brave://flags Chrome 2023 web refresh and Omnibox Chip 2023 flags and vertical tabs are working fine now.. Don't know what causing the issue

@rebron
Copy link
Collaborator

rebron commented Aug 16, 2023

@blaze-107 Can you update to our latest 1.57.47 via brave://settings/help. Those flags shouldn't be effecting anything.

@rebron rebron self-assigned this Aug 16, 2023
@rebron rebron added feature/vertical-tabs needs-investigation A bug not 100% confirmed/fixed labels Aug 16, 2023
@Dean-Corso
Copy link

Hi,

I was trying and testing the vertical tabs feature and found a problem when you do switch from normal tab view to vertical tab view and back to normal view.

Try this:

  • just create few new tabs in Brave
  • now change the tab view to vertical tab view (I have the tab bar on left side)
  • then change the tab view back to normal / default tab view (looks ok so far)
  • now just minimize the Brave browser and maximize it back and now you can see the problem

So the problem is that you just can see only one small icon in the title bar and all tab / cards are not showing. Also you can just see the + icon anywhere on the right side but between of it is nothing where normally the tabs should be to see. So there seems to be a different when using the menu entry "Use vertical Tabs" (right mouse menu) and using the "Use vertical tabs" slider in the settings page of Brave. In case of using the slider (on/off) its working correctly but in case of using the menu entry from right mouse context menu it fails to restore the tabs in normal tab view after a minimize / maximize window operation. Below a image...
Tab_2023-08-17_221257
...as I said, when using the slider then this problem does not happen. Just check this out to find and fix the problem.

There is another issue when using vertical tab view on the left side of Brave brwoser. I'am using a extension called "Bookmark Sidebar" showing the bookmark bar on the left side too in Brave. Problem now when using VTabs bar in Brave on left side too then the sidebar of extension is not showing anymore when moving mouse to left side. So that's bad somehow. I would like to use both on left side. Maybe it would be a good idea to limit the VTabs bar height a little to keep some space where I can move the mouse into and trigger the extension bar in front. You know? Below a image I made what I mean...
Tab2_2023-08-17_221257
...so in this case I have some free area I can move the mouse pointer into to get the extension bookmark sidebar to see when hover into this area and then I could also use / open it. Just have a look and tell me what you think. Thanks.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 18, 2023

@blaze-107 I couldn't reproduce the issue, following your test steps, either in 1.56.20 or 1.57.49. Any additional information you can provide would be great.
cc: @rebron

2023-08-18_14h00_02.mp4

@stephendonner
Copy link

@Dean-Corso Hi! I believe I ran into your issue just now, coincidentally (after originally being unable to reproduce, using the provided steps), so I logged: #32384.

Cheers, thanks for the report!

@rebron
Copy link
Collaborator

rebron commented Sep 11, 2023

@blaze-107 are you still seeing issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: On Deck
Development

No branches or pull requests

5 participants