Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tablet] "Open external links in Brave" is shown when "Split screen mode" is ON and not shown when "Split screen mode" is OFF #32071

Open
hffvld opened this issue Aug 3, 2023 · 1 comment
Assignees
Labels
android-tablet-specific bug OS/Android Fixes related to Android browser functionality QA/Yes

Comments

@hffvld
Copy link
Contributor

hffvld commented Aug 3, 2023

Description

Open external links in Brave is shown when Split screen mode is ON and not shown when Split screen mode is OFF.

Steps to reproduce

  1. Launch Brave
  2. Three-dot menu > Settings > General > Confirm there is no Open external links in Brave option available
  3. Open any other app > Enabled Split screen mode for the Brave and another app
  4. Three-dot menu > Settings > General > Observe that Open external links in Brave option is there

Actual result

Open external links in Brave is shown when Split screen mode is ON and not shown when Split screen mode is OFF. The same is happening for Portrait and Landscape Modes.

1 2
1 2

Expected result

Open external links in Brave must be always shown in settings similar to the phones, or must not be shown at all.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Galaxy Tab S8 (tablet)
  • Android version: Android 13

Brave version

Brave build: 1.56.20
Chromium: 115.0.5790.171 (Official Build) (64-bit)
Revision: cf9067bf10d8f798c24643029af1d24e275646d6-refs/branch-heads/5790@{#1924}

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@hffvld hffvld added OS/Android Fixes related to Android browser functionality bug QA/Yes android-tablet-specific labels Aug 3, 2023
@deeppandya
Copy link

@vlad-hoff very interesting find. we don't show the option for tablet and when we set Brave app in split screen mode, it uses phone configs and that's it shows up. definitely we should resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-tablet-specific bug OS/Android Fixes related to Android browser functionality QA/Yes
Projects
None yet
Development

No branches or pull requests

2 participants