Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site banner #924

Closed
NejcZdovc opened this issue Sep 2, 2018 · 2 comments · Fixed by brave/brave-core#556
Closed

Site banner #924

NejcZdovc opened this issue Sep 2, 2018 · 2 comments · Fixed by brave/brave-core#556
Assignees
@NejcZdovc
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 2, 2018 •
edited by petemill
Loading

Implement site banner which is triggered via donate now button in panel.
Requires rewards panel in #920

Test Plan (@petemill)

  • Enable Rewards
  • Visit a site (brave.com)
  • Open Rewards panel
  • Click Donate
  • Site Banner popup should open on brave.com tab
  • Switching away from tab should hide Banner popup
  • Switching back to brave.com tab should show Banner popup
  • Clicking 'X' in Site Banner popup should close popup
  • Clicking in Site Banner and then pressing ESC should close popup
@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 2, 2018
@NejcZdovc NejcZdovc changed the title Add site banner Site banner Sep 2, 2018
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Sep 3, 2018 •
edited
Loading

blocked on #920 and #669

@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 Sep 3, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0, Releasable builds 0.55.x Sep 5, 2018
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned ryanml Oct 1, 2018
@petemill petemill mentioned this issue Oct 10, 2018
Merged
21 tasks
@bbondy bbondy added the QA/Yes label Oct 10, 2018
@srirambv
Copy link
Contributor

srirambv commented Oct 17, 2018 •
edited by kjozwiak
Loading

Verification Passed on

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Verified passed with

Brave 0.57.1 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X
  • Verified steps from issue

Went through verification using the following build under Win 10 x64 - PASSED

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Donate dialog brave/brave-core
7 participants
@bbondy @kjozwiak @ryanml @NejcZdovc @srirambv @jasonrsadler @LaurenWags