Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search functionality broken under namecheap.com broken #2341

Closed
daniesy opened this issue Dec 3, 2018 · 4 comments
Closed

search functionality broken under namecheap.com broken #2341

daniesy opened this issue Dec 3, 2018 · 4 comments

Comments

@daniesy
Copy link

daniesy commented Dec 3, 2018

Description

The domain search functionality of namecheap.com isn't working

Steps to Reproduce

  1. Go to namecheap.com
  2. Search for a domain
  3. The search results don't appear

Actual result:

screenshot 2018-12-03 at 23 32 11

Expected result:

screenshot 2018-12-03 at 23 35 16

Reproduces how often:

Every time i search for a domain and i have the shields turned on.

Brave version (brave://version info)

Brave | 0.58.10 Chromium: 71.0.3578.53 (Official Build) dev(64-bit)
Revision | 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS | Mac OS X

Reproducible on current release:

  • Yep

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? Yep
  • Is the issue reproducible on the latest version of Chrome? Nope

Additional Information

It happens to many other websites, but this is the last one i remembered. The problem is that i get no warning that content is blocked and, at first, i thought that the website is blocked.

@srirambv
Copy link
Contributor

srirambv commented Dec 4, 2018

Issue is due to CORS policy. Disable shields is the only workaround
image

@srirambv srirambv added webcompat/not-shields-related Sites are breaking because of something other than Shields. workaround/shields-down labels Dec 4, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Dec 4, 2018
@rebron rebron added webcompat/shields Shields is breaking a website. priority/P4 Planned work. We expect to get to it "soon". and removed webcompat/not-shields-related Sites are breaking because of something other than Shields. workaround/shields-down labels Dec 4, 2018
@iefremov
Copy link
Contributor

iefremov commented Jan 9, 2019

Should be fixed together with #2252

@NumDeP
Copy link

NumDeP commented Jan 9, 2019

Thanks guys for fixing this sooner in Brave-Core. This was also apparent in the Muon version as well so quite the wait :)

@btlechowski
Copy link

btlechowski commented Jan 9, 2019

Verification passed on

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

image

Verification PASSED on Mint 19.1 x64 VM using the following build:

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

screen shot 2019-01-09 at 5 46 51 pm

Verified passed with

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

screen shot 2019-01-09 at 6 10 56 pm

@kjozwiak kjozwiak changed the title Website issues: namecheap can't search for domains using namecheap.com Jan 11, 2019
@kjozwiak kjozwiak changed the title can't search for domains using namecheap.com search functionality under namecheap.com broken Jan 11, 2019
@kjozwiak kjozwiak changed the title search functionality under namecheap.com broken search functionality broken under namecheap.com broken Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants