Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check brave_network_delegate_base.cc:GetWebContentsFromProcessAndFrameId #2263

Closed
iefremov opened this issue Nov 28, 2018 · 2 comments
Closed
Assignees

Comments

@iefremov
Copy link
Contributor

iefremov commented Nov 28, 2018

https://github.com/brave/brave-core/blob/master/browser/net/brave_network_delegate_base.cc#L36

Using render_frame_id instead of render_frame_tree_node_id in the return statement seems like a typo, but fixing it causes the browser tests breakage.

The same issue is in the upsream code, see chrome_content_browser_client.cc:GetWebContentsFromProcessAndFrameId

Need to investigate this and fix or add an explaining comment.

Brave version (brave://version info)

Brave 0.59.1 Chromium: 71.0.3578.53 (Developer Build) (64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    yes
@iefremov iefremov self-assigned this Nov 28, 2018
@iefremov
Copy link
Contributor Author

@bbondy FYI

@bbondy bbondy added this to the 1.x Backlog milestone Dec 2, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@iefremov
Copy link
Contributor Author

Fixed after migration to NetworkService

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants