We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/brave/brave-core/blob/master/browser/net/brave_network_delegate_base.cc#L36
Using render_frame_id instead of render_frame_tree_node_id in the return statement seems like a typo, but fixing it causes the browser tests breakage.
render_frame_id
render_frame_tree_node_id
The same issue is in the upsream code, see chrome_content_browser_client.cc:GetWebContentsFromProcessAndFrameId
Need to investigate this and fix or add an explaining comment.
The text was updated successfully, but these errors were encountered:
@bbondy FYI
Sorry, something went wrong.
Fixed after migration to NetworkService
iefremov
No branches or pull requests
https://github.com/brave/brave-core/blob/master/browser/net/brave_network_delegate_base.cc#L36
Using
render_frame_id
instead ofrender_frame_tree_node_id
in the return statement seems like a typo, but fixing it causes the browser tests breakage.The same issue is in the upsream code, see chrome_content_browser_client.cc:GetWebContentsFromProcessAndFrameId
Need to investigate this and fix or add an explaining comment.
Brave version (brave://version info)
Reproducible on current release:
yes
The text was updated successfully, but these errors were encountered: