Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n for 1.24.x release (Chromium 90). #15514

Closed
mkarolin opened this issue Apr 27, 2021 · 3 comments · Fixed by brave/brave-core#8663
Closed

Update l10n for 1.24.x release (Chromium 90). #15514

mkarolin opened this issue Apr 27, 2021 · 3 comments · Fixed by brave/brave-core#8663

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Apr 27, 2021

Download the latest l10n from Transifex.

Test plan:

@brave/legacy_qa should run through a few locals just to make sure that nothing obvious has regressed. Shouldn't spend too much time on this though. Also should check #15514 (comment)

Fix to this issue should also address:

@LaurenWags
Copy link
Member

Generally with 1.24.75 BAT is not being shown correctly (is displaying BAP instead). This is occurring in pretty much all rewards related areas when region = Japan and language = Japanese. This is not happening with 1.25.x.

When these translations get uplifted to 1.24.x, QA needs to (at a minimum) confirm the following areas are correctly showing BAT when bF is enabled, language = Japanese, and region = Japan:

  • brave://rewards
  • rewards panel
  • NTP widget
  • one time and monthly tip banners (confirm BAT Points is removed also, should only be BAT)
  • monthly statement
  • set up a monthly tip and view this tip on the rewards panel

cc @Miyayes @brave/legacy_qa

@LaurenWags
Copy link
Member

LaurenWags commented May 3, 2021

Verification completed using

Brave | 1.24.82 Chromium: 90.0.4430.93 (Build oficial) (x86_64)
-- | --
Revisión | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
SO | macOS Versión 10.15.7 (Fase 19H1030)

Verified test plan from #15514 (comment):

  • For French, spot checked brave://settings, brave://rewards, NTP, shields, and menus to confirm French was being used
  • For Spanish, spot checked brave://settings, brave://rewards, NTP, shields, and menus to confirm Spanish was being used

Verified #15387 is resolved:
Zrzut ekranu 2021-05-3 o 10 28 56

Verified items listed in #15514 (comment). See

Notes
bF KYC wallet connected
brave://rewards NTP widget
rewards page NTP widget
Rewards panel one time tip banner monthly tip banner Rewards panel with monthly tip set up
panel 1 1 time tip monthly tip panel tip
Monthly Statement Monthly Statement Monthly Statement Monthly Statement
stmt1 stmt2 stmt3 stmt4
Anon wallet
brave://rewards NTP widget
スクリーンショット 2021-05-03 12 26 25 rewards
Rewards panel one time tip banner monthly tip banner Rewards panel with monthly tip set up
スクリーンショット 2021-05-03 12 26 48 スクリーンショット 2021-05-03 12 26 57 スクリーンショット 2021-05-03 12 27 03 スクリーンショット 2021-05-03 12 27 24
Monthly Statement Monthly Statement Monthly Statement Monthly Statement
スクリーンショット 2021-05-03 12 30 47 スクリーンショット 2021-05-03 12 30 56 スクリーンショット 2021-05-03 12 31 02 スクリーンショット 2021-05-03 12 31 08

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 3, 2021
@srirambv
Copy link
Contributor

srirambv commented May 6, 2021

Verification passed on OnePlus 6T with Android 10 running 1.24.82 x64 build

  • Verified nothing regressed

Verification passed on Samsung Tab A with Android 10 running 1.24.82 x64 build

  • Verified nothing regressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants