Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Ads Auth Refresh Flow #15600

Closed
jsecretan opened this issue May 3, 2021 · 3 comments · Fixed by brave/brave-core#9350
Closed

New Ads Auth Refresh Flow #15600

jsecretan opened this issue May 3, 2021 · 3 comments · Fixed by brave/brave-core#9350
Assignees
@emerick
Labels
feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.31.x - Release

Comments

@jsecretan
Copy link

https://github.com/brave/internal/issues/769
@jsecretan jsecretan added priority/P3 The next thing for us to work on. It'll ride the trains. feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels May 3, 2021
@emerick emerick mentioned this issue Jul 7, 2021
Merged
24 tasks
@emerick emerick added this to the 1.31.x - Nightly milestone Sep 3, 2021
@emerick emerick mentioned this issue Sep 8, 2021
Closed
@LaurenWags
Copy link
Member

@brave/legacy_qa before starting work on this ping @kjozwiak to discuss test plan

@srirambv
Copy link
Contributor

Removing Android label as this is desktop only. @jsecretan @emerick please update label if you think otherwise

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Oct 12, 2021
@btlechowski btlechowski mentioned this issue Oct 17, 2021
Closed
This was referenced Oct 19, 2021
Open
Open
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Oct 19, 2021 •
edited by stephendonner
Loading

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.31.86 Chromium: 95.0.4638.50 (Official Build) (64-bit)
-- | --
Revision | 3e9db37693d0cf8e31a89fbcf50401ae91125cef-refs/branch-heads/4638@{#816}
OS | Windows 11 Version 21H2 (Build 22000.258)

Verification notes can be found via https://github.com/brave/internal/issues/769#issuecomment-946388708

Verification passed on

Brave 1.31.86 Chromium: 95.0.4638.50 (Official Build) (64-bit)
Revision 3e9db37693d0cf8e31a89fbcf50401ae91125cef-refs/branch-heads/4638@{#816}
OS Ubuntu 18.04 LTS

Verification notes can be found via https://github.com/brave/internal/issues/769#issuecomment-946388708

Verified PASSED using https://github.com/brave/internal/issues/769#issuecomment-946494847

Brave 1.31.86 Chromium: 95.0.4638.50 (Official Build) (x86_64)
Revision 3e9db37693d0cf8e31a89fbcf50401ae91125cef-refs/branch-heads/4638@{#816}
OS macOS Version 11.6 (Build 20G165)

@kjozwiak kjozwiak mentioned this issue Oct 19, 2021
Closed
@btlechowski btlechowski mentioned this issue Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Brave Ads adaptive captcha support brave/brave-core
6 participants
@jsecretan @kjozwiak @emerick @srirambv @LaurenWags @btlechowski