Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS sub menu is not shown in the main app menu until browser is restarted #15822

Closed
GeetaSarvadnya opened this issue May 13, 2021 · 1 comment · Fixed by brave/brave-core#8797

Comments

@GeetaSarvadnya
Copy link

Description

IPFS sub menu is not shown in the main app menu until browser is restarted

Steps to Reproduce

  1. Clean profile 1.25.x
  2. Enable IPFS local node
  3. Click on main menu settings
  4. IPFS sub menu is not shown in the main app menu

Actual result:

IPFS sub menu is not shown in the main app menu after enabling IPFS

Before browser restart:
image

After browser restart:
image

Expected result:

IPFS sub menu should be shown in the main app menu after enabling IPFS

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.25.57 Chromium: 90.0.4430.93 (Official Build) beta (64-bit)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS Windows 10 OS Version 2004 (Build 19041.985)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @spylogsster

@stephendonner
Copy link

stephendonner commented May 17, 2021

Verified PASSED using

Brave 1.26.22 Chromium: 91.0.4472.57 (Official Build) nightly (64-bit)
Revision e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS Windows 10 OS Version 2009 (Build 21382.1)

Steps:

  1. new profile
  2. loaded ipns://brantly.eth
  3. chose Use local node
  4. waited for installation to finish
  5. confirmed that top-level IPFS menu item with sub-menus was usable
example example
interstitial ipfs-menu

(After finding out we install go-ipfs components on platforms, I decided to verify this additionally on macOS, here.)

Verified PASSED using

Brave 1.26.50 Chromium: 91.0.4472.77 (Official Build) beta (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. loaded ipns://brantly.eth
  3. chose Use local node
  4. waited for installation to finish
  5. confirmed that top-level IPFS menu item with sub-menus was usable
example example
interstitial ipfs-menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment