Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added subscription for ipfs mode #8797

Merged
merged 1 commit into from
May 14, 2021
Merged

Added subscription for ipfs mode #8797

merged 1 commit into from
May 14, 2021

Conversation

spylogsster
Copy link
Contributor

Resolves brave/brave-browser#15822

  • Added subscription for ipfs mode

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Remove profile, start browser, check the main menu, the IPFS submenu should not be available
  • install node, setup local node mode in settings, check the main menu, the IPFS submenu should be availabe
  • Play with IPFS modes, the IPFS menu should appear/disappear in runtime without browser restart

@spylogsster spylogsster reopened this May 14, 2021
@spylogsster spylogsster merged commit be53739 into master May 14, 2021
@spylogsster spylogsster deleted the issue-15822 branch May 14, 2021 07:12
@spylogsster spylogsster added this to the 1.26.x - Nightly milestone May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS sub menu is not shown in the main app menu until browser is restarted
2 participants