Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support URL links according to the following document #1603

Closed
bbondy opened this issue Oct 16, 2018 · 1 comment · Fixed by brave/brave-core#643
Closed

Update support URL links according to the following document #1603

bbondy opened this issue Oct 16, 2018 · 1 comment · Fixed by brave/brave-core#643

Comments

@bbondy
Copy link
Member

bbondy commented Oct 16, 2018

https://docs.google.com/spreadsheets/d/16ubLUdPWmbzD4wiiiu0QbEGA6tbhJgqBemp_eVHz3FA/edit#gid=0

QA note:
Best effort if you can find some of the URLs described to make sure they go to the right place.
Don't spend too long but do verify some of them from the PR code.

@srirambv
Copy link
Contributor

srirambv commented Oct 17, 2018

Verification Passed on

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux
  • Verified address bar link under Setting->Search pointed to the correct support link
  • Verified Learn more for WebRTC pointed to the correct GitHub page link

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X
  • Verified that the address bar link under Setting->Search pointed to the correct support link
  • Verified that the Learn more link under Do Not Track opened the correct support link
  • Verified that the ? link under chrome://settings/passwords opened the correct support link
  • Verified that the Learn more link under chrome://settings/resetProfileSettings?origin=userclick opened the correct support link

Verification Passed on

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows
  • Verified that the address bar link under Setting->Search pointed to the correct support link
  • Verified that the Learn more link under Do Not Track opened the correct support link
  • Verified that the ? link under chrome://settings/passwords opened the correct support link
  • Verified that the Learn more link under chrome://settings/resetProfileSettings?origin=userclick opened the correct support link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment