Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Private Tab with & without Tor keyboard shortcuts #1612

Open
tildelowengrimm opened this issue Oct 16, 2018 · 3 comments
Open

New Private Tab with & without Tor keyboard shortcuts #1612

tildelowengrimm opened this issue Oct 16, 2018 · 3 comments
Labels
feature/private-browsing feature/tor priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@tildelowengrimm
Copy link
Contributor

The Chrome/ium defaults for new window is Cmd-N/Ctrl-N. Private windows are Cmd-Shift-N/Ctrl-Shift-N. We initially wanted Private windows with Tor to be Cmd-Opt-N/Ctrl-Alt-N / #1387, but Ctrl+Alt is reserved on Windows. So we shipped with Cmd-Opt-N/Alt-Shift-N, which isn't symmetrical cross-platform, and isn't really in line with the other modifiers on Windows. Is there a better chord progression we can make for these shortcuts?

@bbondy bbondy added this to the 1.x Backlog milestone Oct 16, 2018
@rebron
Copy link
Collaborator

rebron commented Oct 19, 2018

dupe of #1671

@rebron rebron closed this as completed Oct 19, 2018
@rebron rebron modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Oct 19, 2018
@tildelowengrimm
Copy link
Contributor Author

This is a separate issue for finding a better keyboard shortcut for Windows… sometime in the distant future.

@tildelowengrimm tildelowengrimm modified the milestones: Dupe / Invalid / Not actionable, 1.x Backlog Oct 19, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 26, 2018
@dulhaver
Copy link

dulhaver commented Nov 7, 2018

on a snap installation of brave on any Linux system (manjaro in my case but I guess that is not releveant) there is no keyboard shortcut whatsoever for Private Tab with Tor. There should be one though.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/private-browsing feature/tor priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

4 participants