Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking: Private windows & Tor windows - text, menu, and keyboard shortcut issues #1671

Closed
4 tasks done
davidtemkin opened this issue Oct 17, 2018 · 6 comments
Closed
4 tasks done

Tracking: Private windows & Tor windows - text, menu, and keyboard shortcut issues #1671

davidtemkin opened this issue Oct 17, 2018 · 6 comments
Labels
closed/no-milestone feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor feature/user-interface All UI related

Comments

@davidtemkin
Copy link

davidtemkin commented Oct 17, 2018 •
edited by rebron
Loading

@petemill
Copy link
Member

I'll take some of these items as doesn't look like there's an open PR for any

@petemill petemill assigned petemill and unassigned riastradh-brave Oct 18, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 18, 2018
@bbondy
Copy link
Member

bbondy commented Oct 18, 2018

I think this partially overlaps with #738

petemill added a commit to brave/brave-core that referenced this issue Oct 18, 2018
@petemill
Use "Private" terminology and correct case for Off The Record profile…
e5647d1 
… related UI

Partially address brave/brave-browser#1671
Fix brave/brave-browser#738
This was referenced Oct 18, 2018
Merged
Closed
@petemill
Copy link
Member

brave/brave-core#683 fixes the strings from #738 and corrects the title-casing.

brave/brave-core#684 fixes the keys displayed on the Private NTP, and also only shows macOS keys on macOS and non-macOS keys on Win / Linux:
image

Still forthcoming is macOS menu bar item.

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Oct 18, 2018 •
edited
Loading

Ooh, looks like we have a "Private Tabs" string in here rather than "Private Windows". [Suggestion added to brave/brave-core#684 .]

@rebron rebron modified the milestones: 1.x Backlog, 0.56.x - Beta Oct 19, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 19, 2018
@rebron rebron mentioned this issue Oct 19, 2018
Open
petemill added a commit to brave/brave-core that referenced this issue Oct 20, 2018
@petemill
Use "Private" terminology and correct case for Off The Record profile…
2af0b7c 
… related UI

Partially address brave/brave-browser#1671
Fix brave/brave-browser#738
@riastradh-brave riastradh-brave added the feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. label Oct 23, 2018
@petemill petemill changed the title Private windows & Tor windows: text, menu, and keyboard shortcut issues Tracking: Private windows & Tor windows - text, menu, and keyboard shortcut issues Oct 23, 2018
@petemill
Copy link
Member

Updated the description on this issue to show status and sub-issues @tomlowenthal @rebron

@rebron rebron removed this from the 0.56.x - Beta milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@tildelowengrimm tildelowengrimm added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Oct 30, 2018
@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 28, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron
Copy link
Collaborator

rebron commented Apr 28, 2020

Closing this meta issue. Individual issues resolved for 1.0.x or earlier.

@rebron rebron closed this as completed Apr 28, 2020
@rebron rebron added closed/no-milestone and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/no-milestone feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor feature/user-interface All UI related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tildelowengrimm @petemill @bbondy @rebron @davidtemkin @riastradh-brave