Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entry in settings webui for configuring Brave as a default app for microsoft-edge protocol #17558

Closed
simonhong opened this issue Aug 19, 2021 · 1 comment · Fixed by brave/brave-core#10879
Closed

Add entry in settings webui for configuring Brave as a default app for microsoft-edge protocol #17558

simonhong opened this issue Aug 19, 2021 · 1 comment · Fixed by brave/brave-core#10879
Assignees
@simonhong
Labels
design A design change, especially one which needs input from the design team OS/Desktop OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.32.x - Release #2

Comments

@simonhong
Copy link
Member

simonhong commented Aug 19, 2021 •
edited by bsclifton
Loading

This is next step for #13875

  • User could see the status of whether Brave is the default app or not for microsoft-edge protocol from this new settings entry.
  • If not, we can have a button to launch into the proper control panel from settings (like we do for default browser setting) where user can adjust it themselves.
@simonhong simonhong self-assigned this Aug 19, 2021
@simonhong simonhong changed the title Add settings entry for setting brave as a default app for microsoft-edge protocol Add entry in settings webui for configuring Brave as a default app for microsoft-edge protocol Aug 19, 2021
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 19, 2021
@rebron rebron added the design A design change, especially one which needs input from the design team label Sep 7, 2021
@simonhong simonhong mentioned this issue Nov 10, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Nov 10, 2021
@simonhong
Added ms-edge protocol handler option to settings w/o system dialog
3d664c5 
fix brave/brave-browser#17558

Applied below FF's implementation to set default handler w/o using
windows system ui.
https://github.com/mozilla/gecko-dev/blob/master/toolkit/mozapps/defaultagent/SetDefaultBrowser.cpp
simonhong added a commit to brave/brave-core that referenced this issue Nov 15, 2021
@simonhong
Added ms-edge protocol handler option to settings w/o system dialog
aab8dd4 
fix brave/brave-browser#17558

Applied below FF's implementation to set default handler w/o using
windows system ui.
https://github.com/mozilla/gecko-dev/blob/master/toolkit/mozapps/defaultagent/SetDefaultBrowser.cpp
@simonhong simonhong added this to the 1.34.x - Nightly milestone Nov 16, 2021
This was referenced Nov 23, 2021
Merged
Merged
@btlechowski
Copy link

Verification passed on

Brave 1.32.112 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 20H2 (Build 19042.1348)

Verified test plan from brave/brave-core#10879

Test case 1:

default3_1 default3_2 default3_3 default3_4 default3_5 default3_6

Test case 2:

default4_1 default4_2 default4_3 default4_4

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Nov 25, 2021
Closed
@kjozwiak kjozwiak mentioned this issue Nov 25, 2021
Closed
@bsclifton bsclifton mentioned this issue Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
design A design change, especially one which needs input from the design team OS/Desktop OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.32.x - Release #2
Development

Successfully merging a pull request may close this issue.

Added ms-edge protocol handler option brave/brave-core
5 participants
@karenkliu @kjozwiak @rebron @simonhong @btlechowski