Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 93.0.4577.51 to Chromium 93.0.4577.58. #17668

Closed
mkarolin opened this issue Aug 24, 2021 · 3 comments · Fixed by brave/brave-core#9839 or #17671
Closed

Upgrade from Chromium 93.0.4577.51 to Chromium 93.0.4577.58. #17668

mkarolin opened this issue Aug 24, 2021 · 3 comments · Fixed by brave/brave-core#9839 or #17671

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Aug 24, 2021

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/93.0.4577.51..93.0.4577.58?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump
Verify "Affected Areas" from #16306 (comment)

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@LaurenWags
Copy link
Member

@brave/legacy_qa be sure to test all "affected areas" as listed in #16306 (comment)

@stephendonner
Copy link

stephendonner commented Aug 28, 2021

Verified PASSED using

Brave 1.29.74 Chromium: 93.0.4577.58 (Official Build) (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 11.5.2 (Build 20G95)

Also exploratory tested:

  • Sync (general functionality)
  • Settings WebUI, including import dialog, history, downloads, extensions (general functionality)
  • Profile picker
  • Ads (notifications shown)
  • NTP top sites
  • Widevine (installation + general functionality)

Screen Shot 2021-08-28 at 4 07 44 PM


Verification passed on

Brave 1.29.74 Chromium: 93.0.4577.58 (Official Build) (64-bit)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS Linux

Also tested areas:
Sync (general functionality)
Settings WebUI, including import dialog, history, downloads, extensions (general functionality)
Profile picker
Ads (notifications shown)
NTP top sites
Widevine (installation + general functionality)

image


Verification passed on

Brave | 1.29.74 Chromium: 93.0.4577.58 (Official Build) (64-bit)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

@srirambv
Copy link
Contributor

srirambv commented Aug 31, 2021

Verification passed on the following devices running 1.29.76 x64 build

  • Verified the affected areas mentioned
    • New colour scheme in Chromium
    • Sync
    • Ads notifications
    • Stacked overview mode vs tab groups (Mobile only)
Oppo Reno 5 (Android 11) Samsung Tab A (Android 10)

Verification passed on Asus Zenfone (x86) running 1.29.76

x86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment