Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 92 to Chromium 93 #9062

Merged
merged 205 commits into from
Aug 18, 2021
Merged

Upgrade from Chromium 92 to Chromium 93 #9062

merged 205 commits into from
Aug 18, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jun 9, 2021

Fixes brave/brave-browser#16306
Related PR: brave/brave-browser#16679

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Jun 9, 2021
@mariospr mariospr force-pushed the cr93 branch 9 times, most recently from a62667f to 69f011c Compare June 15, 2021 16:01
@mariospr mariospr force-pushed the cr93 branch 11 times, most recently from aaf5f37 to 03f0a04 Compare June 24, 2021 09:57
@mariospr mariospr force-pushed the cr93 branch 5 times, most recently from 32c63d2 to f0ac9fb Compare July 8, 2021 16:09
petemill and others added 19 commits August 18, 2021 10:59
…roperty binding is setup

Previously we were creating the elements directly on the document. That led to the constructor being called immediately. When we create as a template element first then we avoid that issue.
…the actual element.

We need to:
- Make sure chromium's component does not get registered, so we add a dep to a JS module which makes sure the element name is on an ignore list
- Define our own element which subclasses chromium's one and accesses and modifies the original static property
Browser tests error out on Windows CI with

content/public/test/test_utils.cc(137): error: Failed
RunLoop::Run() timed out. Timeout set at ProxyRunTestOnMainThreadLoop@content/public/test/browser_test_base.cc:800.

Running with --disable-gpu avoids the error, but causes various WebGL
tests to fail.

Running with --no-sandbox avoids the error.

Running with --disable-gpu-sandbox also avoids the error - picked this
one is the least bad from the 2 above.

It is not clear ATM what's causing the error.

Only adds the flag on Windows in Release config.
Followup to a prior commit that follows upstream and renames
ProfileSyncService to SyncServiceImpl in various class names.
…ser#10643

This browser tests got moved into //brave/browser/brave_shields but
got removed from its original location, so let's do it now.
This migrates away from WebContentsReceiverSet and avoids having to
friend WebContentsFrameReceiverSetPassKey with BraveDRMTabHelper.
…rSet

This migrates away from WebContentsReceiverSet and avoids having to friend
WebContentsFrameReceiverSetPassKey with BraveShieldsWebContentsObserver.
….cc.patch

I initially thought we'd be better off for now with a one-line patch
to avoid complicating things too much on the verge of the merge, but
turns out that we already subclass ChromeContentBrowserClient, and so
we can avoid patching by overriding BindAssociatedReceiverFromFrame()
from there to extend it with the binders for our own mojo interfaces.
The patch was introduced here #2514
but upstream added the same functionality in Cr81 here
chromium/chromium@432be5c
@mkarolin mkarolin merged commit 09fb27c into master Aug 18, 2021
@mkarolin mkarolin deleted the cr93 branch August 18, 2021 22:08
@mkarolin mkarolin added this to the 1.30.x - Nightly milestone Aug 18, 2021
@mkarolin
Copy link
Collaborator Author

mkarolin commented Aug 18, 2021

mkarolin added a commit that referenced this pull request Aug 24, 2021
Upgrade from Chromium 92 to Chromium 93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 92 to Chromium 93