Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCHECK fails in save_update_with_account_store_bubble_controller.cc. #17595

Closed
szilardszaloki opened this issue Aug 20, 2021 · 2 comments · Fixed by brave/brave-core#9807
Closed
Assignees
Labels

Comments

@szilardszaloki
Copy link
Contributor

Description

The DCHECK in brave-browser\src\chrome\browser\ui\passwords\bubble_controllers\save_update_with_account_store_bubble_controller.cc:108 fails when trying to log in with a service provider (including Uphold, Gemini, Google, FaceBook, etc.).

Steps to Reproduce

Try to log in with Google.

Actual result:

Crash.

Expected result:

No crash.

Reproduces how often:

Easily.

Brave version (brave://version info)

Brave 1.30.37 Chromium: 93.0.4577.51 (Developer Build) (64-bit)
Revision 762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS Windows 10 OS Version 2009 (Build 19043.1165)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@mkarolin

@mkarolin
Copy link
Contributor

mkarolin commented Aug 20, 2021

QA: please, test saving/filling password, including #16926.

mkarolin added a commit to brave/brave-core that referenced this issue Aug 20, 2021
Goes around upstream check for gaia credential page and empty primary
account in the browser.

Fixes brave/brave-browser#17595
Fixes brave/brave-browser#16926
mkarolin added a commit to brave/brave-core that referenced this issue Aug 24, 2021
Goes around upstream check for gaia credential page and empty primary
account in the browser.

Fixes brave/brave-browser#17595
Fixes brave/brave-browser#16926
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 25, 2021
@bsclifton bsclifton added this to the 1.30.x - Nightly milestone Aug 25, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.29.74 Chromium: 93.0.4577.58 (Official Build) (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 11.5.2 (Build 20G95)

Confirmed I was prompted for both Google/Gmail.com and other sites' passwords; also confirmed I was able to auto-fill.

gmail w3c facebook
Screen Shot 2021-08-27 at 8 59 20 AM Screen Shot 2021-08-27 at 9 00 25 AM Screen Shot 2021-08-27 at 9 02 31 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants