CR92 - Not getting save password prompt for Gmail accounts #16926

GeetaSarvadnya · 2021-07-13T16:14:54Z

Description

CR92 - Not getting save password prompt for Gmail accounts

Steps to Reproduce

Clean profile 1.28.74
Open gmail.com and sign in to gmail
Not getting save password prompt

Please note I am seeing this issue only for Gmail accounts, I am getting save password prompt for Twitter and uphold logins

Actual result:

Not getting save password prompt for Gmail accounts

Expected result:

Should get save password prompt for Gmail

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.28.74 Chromium: 92.0.4515.93 (Official Build) nightly (64-bit)
Revision	6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS	Windows 10 OS Version 2004 (Build 19041.1083)

## Version/Channel Information:

Can you reproduce this issue with the current release? No
Can you reproduce this issue with the beta channel? No
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards? NA
Is the issue reproducible on the latest version of Chrome? Yes

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @mkarolin

stephendonner · 2021-07-13T17:02:51Z

Can confirm with

Brave 1.28.76 Chromium: 92.0.4515.93 (Official Build) nightly (x86_64)
Revision  6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS macOS Version 11.4 (Build 20F71)

and

Brave	1.28.74 Chromium: 92.0.4515.93 (Official Build) nightly (64-bit)
Revision	6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS	Linux

I'm also not getting offered to save passwords for Gmail.com.

Can confirm this still works using 1.27.x and 1.26.x on macOS 👍

mkarolin · 2021-07-13T18:58:50Z

Found the upstream bug filed on it, but they closed it as "Won't fix" saying it's an intentional change (without further explanation): https://bugs.chromium.org/p/chromium/issues/detail?id=1220026.

mkarolin · 2021-07-13T19:09:21Z

As mentioned in the bug above, the suspect for this change is the Enable the account data storage for passwords feature which is now turned on by default on Desktop platforms (https://chromium.googlesource.com/chromium/src/+/3d683277dd571f62df6cbe9eb80b4c3823e34971). Disabling this feature via brave://flags results in the Save Password dialog showing up when logging into Gmail.

The feature description in the code is

// Enables a second, Gaia-account-scoped password store for users who are signed
// in but not syncing.

cc: @jumde @fmarier any recommendations on what we should do with this feature?

mkarolin · 2021-07-13T19:57:42Z

Will disable this feature for now.

GeetaSarvadnya · 2021-07-15T07:39:46Z

Verification passed on



Brave | 1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | Windows 10 OS Version 2004 (Build 19041.1083)

Verified the STR from the issue and confirmed save password prompt is shown for Gmail login
Ensured save password prompt is shown for Twitter/Uphold etc

Verified PASSED using

Brave	1.27.105 Chromium: 92.0.4515.93 (Official Build) (x86_64)
Revision	6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS	macOS Version 11.4 (Build 20F71)

Steps:

new profile
launched Brave
loaded gmail.com, linkedin.com, twitter.com, github.com, and facebook.com
input username and password credentials into each, and confirmed I was prompted to save the respective passwords
shut down Brave
relaunched
loaded the above websites, and confirmed I was offered to auto-fill my previously saved passwords
confirmed passwords appeared in brave://settings/passwords

Verification passed on

Brave	1.27.106 Chromium: 92.0.4515.101 (Official Build) (64-bit)
Revision	edb73f4fb624e2ea0cb6f5cc39c9e317ecd3535b-refs/branch-heads/4515@{#1536}
OS	Ubuntu 18.04 LTS

This feature flag no longer works as all the code it wasn't guarding has been removed and password account storage is the only option now. This also means that we will regress on brave/brave-browser#16926 again, but this can be addressed in a different fix. Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1108738 https://chromium.googlesource.com/chromium/src.git/+/90ac58cb2c56df119ca3d5631cbbc3feabb8a82b commit 90ac58cb2c56df119ca3d5631cbbc3feabb8a82b Author: Marc Treib <treib@chromium.org> Date: Fri Jul 9 10:43:20 2021 +0000 B4P cleanup, part 2: Delete old Save/Update bubble PasswordSaveUpdateView has been replaced by PasswordSaveUpdateWithAccountStoreView, similar for the corresponding controller. This CL deletes the old, non-AccountStore versions. This is a no-op on Win/Mac/Linux/ChromeOS (which already always used the new versions) and on Android/iOS (which don't use this UI at all). (Note that ChromeOS doesn't actually use/support the account-scoped storage, since the signed-in non-syncing state doesn't exist. But the new UI code is a strict superset of the old, so using it on ChromeOS as well is just simpler and more consistent - and this was already the case.) This CL also ports some recent unit test improvements (see crrev.com/c/3006215) from the old to the new controller. Bug: 1108738

Goes around upstream check for gaia credential page and empty primary account in the browser. Fixes brave/brave-browser#17595 Fixes brave/brave-browser#16926

This feature flag no longer works as all the code it wasn't guarding has been removed and password account storage is the only option now. This also means that we will regress on brave/brave-browser#16926 again, but this can be addressed in a different fix. Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1108738 https://chromium.googlesource.com/chromium/src.git/+/90ac58cb2c56df119ca3d5631cbbc3feabb8a82b commit 90ac58cb2c56df119ca3d5631cbbc3feabb8a82b Author: Marc Treib <treib@chromium.org> Date: Fri Jul 9 10:43:20 2021 +0000 B4P cleanup, part 2: Delete old Save/Update bubble PasswordSaveUpdateView has been replaced by PasswordSaveUpdateWithAccountStoreView, similar for the corresponding controller. This CL deletes the old, non-AccountStore versions. This is a no-op on Win/Mac/Linux/ChromeOS (which already always used the new versions) and on Android/iOS (which don't use this UI at all). (Note that ChromeOS doesn't actually use/support the account-scoped storage, since the signed-in non-syncing state doesn't exist. But the new UI code is a strict superset of the old, so using it on ChromeOS as well is just simpler and more consistent - and this was already the case.) This CL also ports some recent unit test improvements (see crrev.com/c/3006215) from the old to the new controller. Bug: 1108738

Goes around upstream check for gaia credential page and empty primary account in the browser. Fixes brave/brave-browser#17595 Fixes brave/brave-browser#16926

GeetaSarvadnya added OS/Desktop bug QA/Test-Plan-Specified QA/Yes regression labels Jul 13, 2021

GeetaSarvadnya mentioned this issue Jul 13, 2021

Upgrade from Chromium 91 to Chromium 92 #15316

Closed

rebron assigned mkarolin Jul 13, 2021

rebron added release/blocking priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 13, 2021

mkarolin mentioned this issue Jul 13, 2021

Disables kEnablePasswordsAccountStorage feature. brave/brave-core#9420

Merged

24 tasks

mkarolin closed this as completed in brave/brave-core#9420 Jul 14, 2021

mkarolin added this to the 1.28.x - Nightly milestone Jul 14, 2021

This was referenced Jul 14, 2021

Upgrade from Chromium 91 to Chromium 92 brave/brave-core#8545

Merged

Upgrade from Chromium 91 to Chromium 92 (1.27.x). brave/brave-core#9361

Merged

mkarolin added the release-notes/exclude label Jul 14, 2021

LaurenWags modified the milestones: 1.28.x - Nightly, 1.27.x - Beta Jul 14, 2021

GeetaSarvadnya added the QA Pass-Win64 label Jul 15, 2021

stephendonner added the QA Pass-macOS label Jul 15, 2021

btlechowski added the QA Pass-Linux label Jul 21, 2021

This was referenced Aug 20, 2021

DCHECK fails in save_update_with_account_store_bubble_controller.cc. #17595

Closed

[cr93 followup] Removed disablement of kEnablePasswordsAccountStorage. brave/brave-core#9807

Merged

mkarolin added a commit to brave/brave-core that referenced this issue Aug 20, 2021

Allow offering to save google passwords.

e233a56

Goes around upstream check for gaia credential page and empty primary account in the browser. Fixes brave/brave-browser#17595 Fixes brave/brave-browser#16926

mkarolin added a commit to brave/brave-core that referenced this issue Aug 24, 2021

Allow offering to save google passwords.

d454b1a

Goes around upstream check for gaia credential page and empty primary account in the browser. Fixes brave/brave-browser#17595 Fixes brave/brave-browser#16926

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CR92 - Not getting save password prompt for Gmail accounts #16926

CR92 - Not getting save password prompt for Gmail accounts #16926

GeetaSarvadnya commented Jul 13, 2021

stephendonner commented Jul 13, 2021 •

edited

Loading

mkarolin commented Jul 13, 2021

mkarolin commented Jul 13, 2021 •

edited

Loading

mkarolin commented Jul 13, 2021

GeetaSarvadnya commented Jul 15, 2021 •

edited by btlechowski

Loading

CR92 - Not getting save password prompt for Gmail accounts #16926

CR92 - Not getting save password prompt for Gmail accounts #16926

Comments

GeetaSarvadnya commented Jul 13, 2021

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Other Additional Information:

Miscellaneous Information:

stephendonner commented Jul 13, 2021 • edited Loading

mkarolin commented Jul 13, 2021

mkarolin commented Jul 13, 2021 • edited Loading

mkarolin commented Jul 13, 2021

GeetaSarvadnya commented Jul 15, 2021 • edited by btlechowski Loading

stephendonner commented Jul 13, 2021 •

edited

Loading

mkarolin commented Jul 13, 2021 •

edited

Loading

GeetaSarvadnya commented Jul 15, 2021 •

edited by btlechowski

Loading