Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark button shown twice on URL Bar #915

Closed
srirambv opened this issue Sep 1, 2018 · 2 comments
Closed

Bookmark button shown twice on URL Bar #915

srirambv opened this issue Sep 1, 2018 · 2 comments
Assignees
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 1, 2018

Description

Bookmark button shown twice on URL Bar

Steps to Reproduce

  1. Upgrade to 0.54.4
  2. See two bookmark buttons one inside omnibox and one outside
  3. Click boomkark button inside omnibox, bookmark balloon is shown under the icon which is outside omnibox

Actual result:

bookmarkbutton

Expected result:

Should not show the button inside omnibox

Reproduces how often:

100%

Brave version (about:brave info)

Brave 0.54.4 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)
Revision 1911f781145b803e04f2d0b5b1a0146ae69fcbdc-refs/branch-heads/3528@{#9}
OS Windows

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @bbondy please move to 0.55.x milestone if required

@simonhong
Copy link
Member

brave/brave-core#379 will fix this issue

@bbondy
Copy link
Member

bbondy commented Sep 1, 2018

Closing as a duplicate to #899

@bbondy bbondy closed this as completed Sep 1, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, Dupe / Invalid Sep 1, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

4 participants