We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't be able to set validation-failed gateway strings.
Found while testing #16999.
brave://settings/ipfs
Change
IPFS public gateway fallback
https://blah
Submit
IPFS public gateway address
I was able to set https://blah as the gateway host, even though it failed validation.
Should still be the default https://dweb.link after throwing the error message.
https://dweb.link
100%
/cc @spylogsster @lidel
The text was updated successfully, but these errors were encountered:
Verified PASSED using the inline test plan with
PASSED
Confirmed I received Invalid gateway address error message in the dialog, and the Submit button didn't do anything.
Invalid gateway address
Verified PASSED using
Sorry, something went wrong.
Updated to release-notes/exclude per discussion with @rebron and @kjozwiak
release-notes/exclude
spylogsster
Successfully merging a pull request may close this issue.
Description
Shouldn't be able to set validation-failed gateway strings.
Found while testing #16999.
Steps to Reproduce
brave://settings/ipfs
Change
button forIPFS public gateway fallback
https://blah
Submit
brave://settings/ipfs
forIPFS public gateway address
Actual result:
I was able to set
https://blah
as the gateway host, even though it failed validation.Expected result:
Should still be the default
https://dweb.link
after throwing the error message.Reproduces how often:
100%
Brave version (brave://version info)
/cc @spylogsster @lidel
The text was updated successfully, but these errors were encountered: