Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use valid validation gateway in dialog #9815

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Use valid validation gateway in dialog #9815

merged 1 commit into from
Aug 23, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Aug 22, 2021

Resolves brave/brave-browser#17604

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. new profile
  2. launch Brave
  3. load brave://settings/ipfs
  4. click on the Change button for IPFS public gateway fallback
  5. enter https://blah
  6. click Submit
  7. notice the error message
  8. cancel the dialog
  9. look at the value in brave://settings/ipfs for IPFS public gateway address

@spylogsster spylogsster self-assigned this Aug 22, 2021
@spylogsster spylogsster merged commit d0036e8 into master Aug 23, 2021
@spylogsster spylogsster deleted the isse-17604 branch August 23, 2021 13:22
@spylogsster spylogsster added this to the 1.30.x - Nightly milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shouldn't be able to set validation-failed gateway strings
2 participants