Force network requests from YouTube to be blocked in aggressive mode

[antonok-edm]

YouTube sometimes breaks spectacularly when not kept in sync with uBlock Origin's upstream filter changes. We should keep our behavior on *.youtube.com as similar as possible, meaning kept in aggressive mode at all times.

[antonok-edm]

Leaving this as release-notes/exclude because it's a tweak to the bigger change in #17366

[Ayern12]

##owh you is commander pattner

…

On Sat, 21 Aug 2021, 02:04 Anton Lazarev, ***@***.***> wrote: YouTube sometimes breaks spectacularly when not kept in sync with uBlock Origin's upstream filter changes. We should keep our behavior on *. youtube.com as similar as possible, meaning kept in aggressive mode at all times. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17607>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVINGPYRERVAKWZJFLWW6FDT52KJ5ANCNFSM5CQYYKGA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[stephendonner]

Verified PASSED using

Brave	1.30.42 Chromium: 93.0.4577.51 (Official Build) nightly (x86_64)
Revision	762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS	macOS Version 11.5.2 (Build 20G95)

YouTube.com Steps:

1. Set the brave-adblock-default-1p-blocking flag to Disabled in brave://flags.
2. Visited youtube.com and clicked on a video.
3. Ensured no pre-roll ads appear.
4. Verified that there are blocked requests in the Shields panel, and that at least one is from youtube.com or one of its subdomains.

example	example

m.YouTube.com Steps:

1. Set the brave-adblock-default-1p-blocking flag to Disabled in brave://flags.
2. Visited https://m.youtube.com/?persist_app=1&app=m and clicked on a video.
3. Ensured no pre-roll ads appear.
4. Verified that there are blocked requests in the Shields panel, and that at least one is from youtube.com or one of its subdomains.

example	example

---

---

Verified PASSED using

Brave 1.30.63 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Linux

YouTube.com Steps:

1. Set the brave-adblock-default-1p-blocking flag to Disabled in brave://flags.
2. Visited youtube.com and clicked on a video.
3. Ensured no pre-roll ads appear.
4. Verified that there are blocked requests in the Shields panel, and that at least one is from youtube.com or one of its subdomains.

example	example

m.YouTube.com Steps:

1. Set the brave-adblock-default-1p-blocking flag to Disabled in brave://flags.
2. Visited https://m.youtube.com/?persist_app=1&app=m and clicked on a video.
3. Ensured no pre-roll ads appear.
4. Verified that there are blocked requests in the Shields panel, and that at least one is from youtube.com or one of its subdomains.

example

---

Verification passed on

Brave | 1.30.65 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

• Verified the test plan from Force aggressive blocking on youtube.com brave-core#9808

youtube.com

Verified that there are blocked requests in the Shields panel and that at least one is from youtube.com or one of its subdomains.

example	example

m.youtube.com

Verified that there are blocked requests in the Shields panel and that at least one is from youtube.com or one of its subdomains.

example	example

[srirambv]

Verification passed on Oppo Reno 5 with Android 11 running 1.30.76 x64 beta build

• Verified test plan from brave-core#9808
• Verified disabling flag doesn't show pre-roll ads on youtube.com or m.youtube.com

---

Verification passed on Samsung Tab A with Android 10 running 1.30.76 x64 beta build

• Verified test plan from brave-core#9808
• Verified disabling flag doesn't show pre-roll ads on youtube.com or m.youtube.com