Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force aggressive blocking on youtube.com #9808

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#17607

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Disable the brave-adblock-default-1p-blocking flag in brave://flags.
  2. Visit youtube.com and click on a video.
  3. Ensure no pre-roll ads appear.
  4. Verify that there are blocked requests in the Shields panel, and that at least one is from youtube.com or one of its subdomains.

Also, repeat the above for m.youtube.com.

@antonok-edm antonok-edm force-pushed the youtube-force-aggressive-blocking branch from 03b81ed to 95bea74 Compare August 20, 2021 18:11
Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force network requests from YouTube to be blocked in aggressive mode
3 participants