Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr93 followup] Turn off kReadLater feature by default #17573

Closed
mkarolin opened this issue Aug 19, 2021 · 2 comments · Fixed by brave/brave-core#9792
Closed

[cr93 followup] Turn off kReadLater feature by default #17573

mkarolin opened this issue Aug 19, 2021 · 2 comments · Fixed by brave/brave-core#9792
Assignees
@mkarolin
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.29.x - Release

Comments

@mkarolin
Copy link
Contributor

This feature got turned on by default on Desktop in cr93. We need to turn it back off.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/8bdb3b260d33741fc75658e511751cacc1b9f4c7

@rebron says "We need to disable Reading List for now, we need to make a modification to the bookmarks UI window, otherwise there’s no UX to actually use Reading List."
@mkarolin mkarolin self-assigned this Aug 19, 2021
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 19, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Aug 19, 2021
@mkarolin
[cr93 followup] Disables kReadLater feature.
5759a32 
Fixes brave/brave-browser#17573
This was referenced Aug 19, 2021
Merged
Merged
mkarolin added a commit to brave/brave-core that referenced this issue Aug 20, 2021
@mkarolin
[cr93 followup] Disables kReadLater feature.
84def00 
Fixes brave/brave-browser#17573
@bsclifton bsclifton added this to the 1.30.x - Nightly milestone Aug 24, 2021
@mkarolin mkarolin mentioned this issue Aug 24, 2021
Merged
24 tasks
@rebron rebron mentioned this issue Sep 8, 2021
Closed
@huyz
Copy link

huyz commented Jan 10, 2022

Enabling brave://flags/#read-later worked for me in v1.38.80 on macOS.
I didn't even need to enable brave://flags/#side-panel which I've read was needed in the past.
Can this feature be enabled by default now?

@dairefagan
Copy link

On linux stable v1.35.100 I can access reading list but only by using #read-later and #side-panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging a pull request may close this issue.

[cr93 followup] Disables kReadLater feature. brave/brave-core
6 participants
@huyz @kjozwiak @bsclifton @rebron @dairefagan @mkarolin