Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave crashes on Android 5 tablet when the Twitter app is launched #17735

Closed
AlexeyBarabash opened this issue Aug 27, 2021 · 2 comments · Fixed by brave/brave-core#9901
Closed

Brave crashes on Android 5 tablet when the Twitter app is launched #17735

AlexeyBarabash opened this issue Aug 27, 2021 · 2 comments · Fixed by brave/brave-core#9901
Assignees
@AlexeyBarabash
Labels
crash OS/Android Fixes related to Android browser functionality QA Pass - Android x86 QA/Test-Plan-Specified QA/Yes release-notes/include x86 Android x86 related issues
Milestone
1.29.x - Release #2

Comments

@AlexeyBarabash
Copy link
Contributor

Description

This issue is originally reported in https://twitter.com/nicolasvillar99/status/1430249154857652230 by Nicolás Villar. Also Nicolás provided huge help while we were trying to reproduce it.

Steps to reproduce

  1. Take Android 5.1 Emulator of Nexus 7 2012 with Android services
  2. Install Brave x86, I used Bravex86.apk from https://github.com/brave/brave-browser/releases/tag/v1.28.106
  3. Launch Brave, skip all first run wizards, open some page
  4. Install twitter on emulator
  5. launch twitter

Actual result

There is a message that Brave crashed
Screenshot from 2021-08-27 19-12-40

and the messages in logcat:

2021-08-27 19:12:25.553 1886-2345/com.android.systemui D/EGL_emulation: eglMakeCurrent: 0xafc2f0a0: ver 3 1 (tinfo 0xafc0b700)
2021-08-27 19:12:25.559 1189-1189/? I/DEBUG: *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
2021-08-27 19:12:25.559 1189-1189/? I/DEBUG: Build fingerprint: 'generic_x86/sdk_google_phone_x86/generic_x86:5.0.2/LSY66K/6695550:eng/test-keys'
2021-08-27 19:12:25.559 1189-1189/? I/DEBUG: Revision: '0'
2021-08-27 19:12:25.559 1189-1189/? I/DEBUG: ABI: 'x86'
2021-08-27 19:12:25.559 1189-1189/? I/DEBUG: pid: 3457, tid: 3457, name: m.brave.browser  >>> com.brave.browser <<<
2021-08-27 19:12:25.559 1189-1189/? I/DEBUG: signal 4 (SIGILL), code 2 (ILL_ILLOPN), fault addr 0x98badb61
2021-08-27 19:12:25.563 1189-1189/? I/DEBUG: Abort message: '[FATAL:jni_android.cc(306)] Please include Java exception stack in crash report
    '
2021-08-27 19:12:25.563 1189-1189/? I/DEBUG:     eax 00000000  ebx 9bc359dc  ecx 00000001  edx 00000000
2021-08-27 19:12:25.563 1189-1189/? I/DEBUG:     esi bfa86478  edi bfa868a0
2021-08-27 19:12:25.563 1189-1189/? I/DEBUG:     xcs 00000073  xds 0000007b  xes 0000007b  xfs 00000007  xss 0000007b
2021-08-27 19:12:25.563 1189-1189/? I/DEBUG:     eip 98badb61  ebp bfa868a0  esp bfa86420  flags 00210246
2021-08-27 19:12:25.563 1189-1189/? I/DEBUG: backtrace:
2021-08-27 19:12:25.563 1189-1189/? I/DEBUG:     #00 pc 02cb1b61  /data/app/com.brave.browser-1/base.apk
2021-08-27 19:12:25.563 1189-1189/? I/DEBUG:     #01 pc 00000002  <unknown>
2021-08-27 19:12:25.563 1189-1189/? I/DEBUG:     #02 pc 02cb1b6f  /data/app/com.brave.browser-1/base.apk
2021-08-27 19:12:25.563 1189-1189/? I/DEBUG:     #03 pc 045cec80  <unknown>

and

2021-08-27 19:12:25.223 4249-4367/com.twitter.android W/OpenGLRenderer: Failed to choose config with EGL_SWAP_BEHAVIOR_PRESERVED, retrying without...
2021-08-27 19:12:25.226 4249-4367/com.twitter.android D/EGL_emulation: eglCreateContext: 0xb02d5ee0: maj 3 min 1 rcv 4
2021-08-27 19:12:25.255 3457-3457/com.brave.browser W/System.err: java.lang.ClassCastException: android.app.ContextImpl cannot be cast to android.app.Activity
2021-08-27 19:12:25.255 3457-3457/com.brave.browser W/System.err:     at Ht.<init>(chromium-ChromePublic.apk-stable-412810611:7)
2021-08-27 19:12:25.255 3457-3457/com.brave.browser W/System.err:     at org.chromium.chrome.browser.toolbar.top.a.onFinishInflate(chromium-ChromePublic.apk-stable-412810611:22)
2021-08-27 19:12:25.255 3457-3457/com.brave.browser W/System.err:     at org.chromium.chrome.browser.customtabs.features.toolbar.CustomTabToolbar.onFinishInflate(chromium-ChromePublic.apk-stable-412810611:1)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at android.view.LayoutInflater.rInflate(LayoutInflater.java:814)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at android.view.LayoutInflater.inflate(LayoutInflater.java:414)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at android.view.ViewStub.inflate(ViewStub.java:264)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at org.chromium.chrome.browser.toolbar.top.ToolbarControlContainer.c(chromium-ChromePublic.apk-stable-412810611:5)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at vh2.b(chromium-ChromePublic.apk-stable-412810611:12)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at eU.run(chromium-ChromePublic.apk-stable-412810611:4)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at rz.run(chromium-ChromePublic.apk-stable-412810611:10)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at android.os.MessageQueue.nativePollOnce(Native Method)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at android.os.MessageQueue.next(MessageQueue.java:143)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at android.os.Looper.loop(Looper.java:122)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at android.app.ActivityThread.main(ActivityThread.java:5221)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at java.lang.reflect.Method.invoke(Native Method)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at java.lang.reflect.Method.invoke(Method.java:372)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
2021-08-27 19:12:25.256 3457-3457/com.brave.browser W/System.err:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)

Expected result

No crash

Issue reproduces how often

I could reproduce it easy.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Didn't tried
  • Can you reproduce this issue with the current Play Store Nightly version? Didn't tried

Device details

  • Install type (ARM, x86): x86, but user reported that for ARM
  • Device type (Phone, Tablet, Phablet): Tablet (may be important)
  • Android version: 5.1 and 5.0 (may be important)

Brave version

v1.28.106

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information
@AlexeyBarabash AlexeyBarabash added crash OS/Android Fixes related to Android browser functionality labels Aug 27, 2021
@AlexeyBarabash
Copy link
Contributor Author

Here is the similar stack from the Debug version with proper names:

2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err: java.lang.ClassCastException: android.app.ContextImpl cannot be cast to android.app.Activity
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at org.chromium.chrome.browser.shields.BraveShieldsHandler.<init>(BraveShieldsHandler.java:7)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at org.chromium.chrome.browser.toolbar.top.BraveToolbarLayoutImpl.onFinishInflate(BraveToolbarLayoutImpl.java:24)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at org.chromium.chrome.browser.customtabs.features.toolbar.CustomTabToolbar.onFinishInflate(CustomTabToolbar.java:1)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at android.view.LayoutInflater.rInflate(LayoutInflater.java:814)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at android.view.LayoutInflater.inflate(LayoutInflater.java:414)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at android.view.ViewStub.inflate(ViewStub.java:264)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at org.chromium.chrome.browser.toolbar.top.ToolbarControlContainer.initWithToolbar(ToolbarControlContainer.java:5)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at org.chromium.chrome.browser.WarmupManager.initializeViewHierarchy(WarmupManager.java:12)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at org.chromium.chrome.browser.customtabs.CustomTabsConnection$$ExternalSyntheticLambda2.run(R8$$SyntheticClass:4)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at org.chromium.chrome.browser.init.ChainedTasks$1.run(ChainedTasks.java:10)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at android.os.MessageQueue.nativePollOnce(Native Method)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at android.os.MessageQueue.next(MessageQueue.java:143)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at android.os.Looper.loop(Looper.java:122)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at android.app.ActivityThread.main(ActivityThread.java:5221)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at java.lang.reflect.Method.invoke(Native Method)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at java.lang.reflect.Method.invoke(Method.java:372)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
2021-08-27 19:58:02.502 5348-5348/com.brave.browser_default W/System.err:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
2021-08-27 19:58:02.509 5348-5348/com.brave.browser_default A/chromium: [FATAL:jni_android.cc(306)] Please include Java exception stack in crash report
2021-08-27 19:58:02.509 5348-5348/com.brave.browser_default A/chromium: #00 pc 0x0013ca5e /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.509 5348-5348/com.brave.browser_default A/chromium: #01 pc 0x0015e8dd /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.509 5348-5348/com.brave.browser_default A/chromium: #02 pc 0x0027b6c2 /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.509 5348-5348/com.brave.browser_default A/chromium: #03 pc 0x00261f7e /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.509 5348-5348/com.brave.browser_default A/chromium: #04 pc 0x00287443 /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.509 5348-5348/com.brave.browser_default A/chromium: #05 pc 0x00287635 /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.509 5348-5348/com.brave.browser_default A/chromium: #06 pc 0x001d6e73 /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.509 5348-5348/com.brave.browser_default A/chromium: #07 pc 0x001fa721 /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #08 pc 0x001f9e56 /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #09 pc 0x001fae03 /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #10 pc 0x00260f6d /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #11 pc 0x00260f0b /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #12 pc 0x00260a7e /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #13 pc 0x00019700 /system/lib/libutils.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #14 pc 0x0001b892 /system/lib/libutils.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #15 pc 0x0001baa7 /system/lib/libutils.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #16 pc 0x000c6327 /system/lib/libandroid_runtime.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #17 pc 0x000c638a /system/lib/libandroid_runtime.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #18 pc 0x000d6f9a /data/dalvik-cache/x86/system@framework@boot.oat
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: Task trace:
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #00 pc 0x00286e88 /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so
2021-08-27 19:58:02.510 5348-5348/com.brave.browser_default A/chromium: #01 pc 0x00286e88 /data/app/com.brave.browser_default-1/lib/x86/libbase.cr.so

AlexeyBarabash added a commit to brave/brave-core that referenced this issue Aug 30, 2021
@AlexeyBarabash
Fix wrong cast exception on Android 5; fixes brave/brave-browser#17735
7801ef5
@AlexeyBarabash AlexeyBarabash self-assigned this Aug 30, 2021
@AlexeyBarabash AlexeyBarabash mentioned this issue Aug 30, 2021
Merged
23 tasks
@AlexeyBarabash AlexeyBarabash added this to the 1.31.x - Nightly milestone Aug 30, 2021
This was referenced Aug 31, 2021
Merged
Merged
kjozwiak added a commit to brave/brave-core that referenced this issue Sep 1, 2021
@kjozwiak
Merge pull request #9919 from brave/pr9901_fix_crash_a5_17735_1.30.x
b3833a8 
Fix wrong cast exception on Android 5; fixes brave/brave-browser#17735 (uplift to 1.30.x)
kjozwiak added a commit to brave/brave-core that referenced this issue Sep 1, 2021
@kjozwiak
Merge pull request #9920 from brave/pr9901_fix_crash_a5_17735_1.29.x
ca07200 
Fix wrong cast exception on Android 5; fixes brave/brave-browser#17735 (uplift to 1.29.x)
@kjozwiak kjozwiak added release-notes/include x86 Android x86 related issues and removed release-notes/exclude labels Sep 2, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Sep 3, 2021 •
edited by srirambv
Loading

Verification PASSED using Nexus 7 (2012) running Android 5.0.2 (Google Services) via Android Studio using https://github.com/brave/brave-browser/releases/download/v1.29.77/Bravex86.apk

1.29.77 Chromium: 93.0.4577.63

Using the STR/Cases outlined via #17735 (comment) & brave/brave-core#9901 (comment), ensured that opening Twitter didn't crash Brave while it was running as per the following:

noCrash

Verification passed on Nexus 7 device running Android 5.0 (Google Services) using AVD emulator

  • Verified steps from issue description
  • Verified there was no crash when Twitter app was launched

image

@srirambv srirambv mentioned this issue Sep 3, 2021
Closed
@kjozwiak kjozwiak mentioned this issue Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
crash OS/Android Fixes related to Android browser functionality QA Pass - Android x86 QA/Test-Plan-Specified QA/Yes release-notes/include x86 Android x86 related issues
Projects
None yet
Milestone
1.29.x - Release #2
Development

Successfully merging a pull request may close this issue.

Fix wrong cast exception on Android 5; fixes brave/brave-browser#17735 brave/brave-core
2 participants
@kjozwiak @AlexeyBarabash