Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in ads::GetParentSegment #17865

Closed
tmancey opened this issue Sep 3, 2021 · 2 comments · Fixed by brave/brave-core#10200
Closed

Crash in ads::GetParentSegment #17865

tmancey opened this issue Sep 3, 2021 · 2 comments · Fixed by brave/brave-core#10200

Comments

@tmancey
Copy link
Contributor

tmancey commented Sep 3, 2021

[ 00 ] ads::GetParentSegment(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
[ 01 ] ads::GetParentSegments(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&)
[ 02 ] void std::__1::__function::__policy_invoker<void (bool, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::vector<ads::CreativeAdNotificationInfo, std::__1::allocator<ads::CreativeAdNotificationInfo> > const&)>::__call_impl<std::__1::__function::__default_alloc_func<ads::ad_notifications::EligibleAds::GetForParentChildSegments(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::vector<ads::AdEventInfo, std::__1::allocator<ads::AdEventInfo> > const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::function<void (bool, std::__1::vector<ads::CreativeAdNotificationInfo, std::__1::allocator<ads::CreativeAdNotificationInfo> > const&)>) const::$_1, void (bool, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::vector<ads::CreativeAdNotificationInfo, std::__1::allocator<ads::CreativeAdNotificationInfo> > const&)> >(std::__1::__function::__policy_storage const*, bool, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::vector<ads::CreativeAdNotificationInfo, std::__1::allocator<ads::CreativeAdNotificationInfo> > const&)
[ 03 ] ads::database::table::CreativeAdNotifications::OnGetForSegments(mojo::StructPtr<ads::mojom::DBCommandResponse>, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::function<void (bool, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::vector<ads::CreativeAdNotificationInfo, std::__1::allocator<ads::CreativeAdNotificationInfo> > const&)>)
[ 04 ] void std::__1::__function::__policy_invoker<void (mojo::StructPtr<ledger::mojom::DBCommandResponse>)>::__call_impl<std::__1::__function::__default_alloc_func<std::__1::__bind<void (ledger::database::DatabaseServerPublisherBanner::*)(mojo::StructPtr<ledger::mojom::DBCommandResponse>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::function<void (mojo::StructPtr<ledger::mojom::PublisherBanner>)>), ledger::database::DatabaseServerPublisherBanner*, std::__1::placeholders::__ph<1> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::function<void (mojo::StructPtr<ledger::mojom::PublisherBanner>)>&>, void (mojo::StructPtr<ledger::mojom::DBCommandResponse>)> >(std::__1::__function::__policy_storage const*, mojo::StructPtr<ledger::mojom::DBCommandResponse>&&)
[ 05 ] bat_ads::OnRunDBTransaction(std::__1::function<void (mojo::StructPtr<ads::mojom::DBCommandResponse>)> const&, mojo::StructPtr<ads::mojom::DBCommandResponse>)
[ 06 ] base::internal::Invoker<base::internal::BindState<void (*)(std::__1::function<void (mojo::StructPtr<ads::mojom::DBCommandResponse>)> const&, mojo::StructPtr<ads::mojom::DBCommandResponse>), std::__1::function<void (mojo::StructPtr<ads::mojom::DBCommandResponse>)> >, void (mojo::StructPtr<ads::mojom::DBCommandResponse>)>::RunOnce(base::internal::BindStateBase*, mojo::StructPtr<ads::mojom::DBCommandResponse>&&)
[ 07 ] bat_ads::mojom::BatAdsClient_RunDBTransaction_ForwardToCallback::Accept(mojo::Message*)
[ 08 ] mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*)
[ 09 ] mojo::MessageDispatcher::Accept(mojo::Message*)
[ 10 ] mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*)
[ 11 ] mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*)
[ 12 ] mojo::internal::MultiplexRouter::Accept(mojo::Message*)
[ 13 ] mojo::MessageDispatcher::Accept(mojo::Message*)
[ 14 ] mojo::Connector::DispatchMessage(mojo::Message)
[ 15 ] mojo::Connector::ReadAllAvailableMessages()
[ 16 ] mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&)
[ 17 ] base::TaskAnnotator::RunTask(char const*, base::PendingTask*)
[ 18 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
[ 19 ] non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
[ 20 ] base::MessagePumpDefault::Run(base::MessagePump::Delegate*)
[ 21 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta)
[ 22 ] base::RunLoop::Run(base::Location const&)
[ 23 ] content::UtilityMain(content::MainFunctionParams const&)
[ 24 ] content::ContentMainRunnerImpl::Run(bool)
[ 25 ] content::ContentMain(content::ContentMainParams const&)
[ 26 ] ChromeMain
[ 27 ] 0x7f73ee10ffa7
[ 28 ] __cpu_indicator_init
[ 29 ] 0x55d9590fd400
[ 30 ] 0x7f73ee0ed0b3
[ 31 ] zcr_extended_drag_v1_destroy(zcr_extended_drag_v1*) (.e819b25963a51bc4badb2cc4667b8d10)
[ 32 ] __cpu_indicator_init
[ 33 ] 0x55d9590fd400
[ 34 ] 0x55d9590fd400
[ 35 ] _start

https://brave.sp.backtrace.io/p/brave/debug?filters=(_deleted%3D0%2C(callstack%2Ccontains%2Cads%3A%3AGetParentSegment)%2C(fingerprint%3Bissues%3Bstate%2Cregex%2Copen%7Cin-progress)%2C(callstack%2Cregex%2Cbrave_ads%7Cbat_ads%7Cbat-native-ads))&fingerprint=0000000000000000000000000000000000000000000000000000000000000526

@tmancey
Copy link
Contributor Author

tmancey commented Oct 7, 2021

@aseren waiting for #18628 to be merged to find the root cause

@aseren aseren added this to the 1.32.x - Beta milestone Oct 15, 2021
@stephendonner
Copy link

stephendonner commented Oct 20, 2021

Verified PASSED using

Brave 1.32.74 Chromium: 95.0.4638.54 (Official Build) dev (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS macOS Version 11.6 (Build 20G165)

using the testplan at brave/brave-core#10200 (comment)

Steps:

  1. new profile
  2. launched Brave
  3. enabled Rewards
  4. loaded espn.com
  5. looked in the console logs for Successfully initialized...
[72707:259:1019/141316.947292:VERBOSE1:epsilon_greedy_bandit_processor.cc(124)] Successfully initialized epsilon greedy bandit arms
<snip>
[72707:259:1019/141317.136863:VERBOSE1:purchase_intent_resource.cc(57)] Successfully initialized bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
<snip>
[72707:259:1019/141317.764779:VERBOSE1:text_classification_resource.cc(59)] Successfully initialized feibnmjhecfbjpeciancnchbmlobenjn text classification resource

Also verified there were no crashes.


Verification passed on

Brave 1.32.76 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#10200 (comment)

Verified logs:

[14669:14669:1025/193720.401925:VERBOSE1:purchase_intent_resource.cc(57)] Successfully initialized bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
[14669:14669:1025/193720.402431:VERBOSE1:anti_targeting_resource.cc(53)] Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig
[14669:14669:1025/193720.402797:VERBOSE1:conversions_resource.cc(50)] Successfully initialized resource nnqccijfhvzwyrxpxwjrpmynaiazctqb
[14669:14669:1025/193719.427367:VERBOSE1:epsilon_greedy_bandit_processor.cc(124)] Successfully initialized epsilon greedy bandit arms

Verified no crashes


Verification passed on

Brave | 1.32.78 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | Windows 10 Version 21H1 (Build 19043.1288)

Verified test plan from brave/brave-core#10200 (comment) and ensured logs are shown as below.
Confirmed there are no crash

[27132:28428:1025/192938.467:VERBOSE1:purchase_intent_resource.cc(57)] Successfully initialized bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
[27132:28428:1025/192938.476:VERBOSE1:anti_targeting_resource.cc(53)] Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig
[27132:28428:1025/192938.483:VERBOSE1:conversions_resource.cc(50)] Successfully initialized resource nnqccijfhvzwyrxpxwjrpmynaiazctqb
[27132:28428:1025/192934.463:VERBOSE1:epsilon_greedy_bandit_processor.cc(124)] Successfully initialized epsilon greedy bandit arms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants