Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: reset profile dialog shows checkbox to report current settings #18077

Closed
mkarolin opened this issue Sep 14, 2021 · 1 comment · Fixed by brave/brave-core#10075
Closed

Regression: reset profile dialog shows checkbox to report current settings #18077

mkarolin opened this issue Sep 14, 2021 · 1 comment · Fixed by brave/brave-core#10075
Assignees
@mkarolin
Labels
OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.30.x - Release

Comments

@mkarolin
Copy link
Contributor

Not sure when this regressed. Present in 1.29.x+

image

The footer with the checkbox should be removed.

STR:

  1. Start Brave
  2. Navigate to brave://settings/reset
  3. Click on Restore settings to their original defaults
    Observer the dialog.
@mkarolin mkarolin self-assigned this Sep 14, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Sep 14, 2021
@mkarolin
Fixes reset profile dialog.
e5903ca 
Hides the footer that offers to send settings to Brave.

Fixes brave/brave-browser#18077
@mkarolin mkarolin mentioned this issue Sep 14, 2021
Merged
24 tasks
@mkarolin mkarolin added this to the 1.31.x - Nightly milestone Sep 14, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.31.44 Chromium: 94.0.4606.41 (Official Build) nightly (x86_64)
Revision 333e85df3c9b656b518b5f1add5ff246365b6c24-refs/branch-heads/4606@{#845}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://settings/reset
  4. clicked on Restore settings to their original defaults
  5. examine the dialog / text

Confirmed the Help make Brave better... option is removed

Screen Shot 2021-09-15 at 8 46 39 AM

This was referenced Sep 16, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.30.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes reset profile dialog. brave/brave-core
3 participants
@stephendonner @kjozwiak @mkarolin