Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset change needed for Tips from Donations #1825

Closed
jenn-rhim opened this issue Oct 24, 2018 · 5 comments · Fixed by brave/brave-core#1217
Closed

Asset change needed for Tips from Donations #1825

jenn-rhim opened this issue Oct 24, 2018 · 5 comments · Fixed by brave/brave-core#1217

Comments

@jenn-rhim
Copy link

Description

As the feature name has changed, the graphic representation needs to be replaced accordingly.

Current:
image

Updated: (assets attached, for Welcome & Settings page)
screen shot 2018-10-24 at 1 18 52 pm

assets-2.zip

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv
Copy link
Contributor

@jenn-rhim any chance we can change it from the thumbs up to something else. Looks too close to FB icon.

@jenn-rhim
Copy link
Author

@srirambv 'Like' gesture is what we want to communicate, associating with tipping. Most sites we want to enable this feature use either thumbs up or heart. Heart is already used for Auto-contribute, so we went with thumbs up. YouTube and Twitter being the first platforms we'll support.

  • we're not creating our own 'Thumbs up' icon, but referring to ones that users will use in those platforms.
  • looking closely here:
    image
    There isn't a huge difference but enough difference here. Do you still think it looks like FB icon?

@bbondy bbondy added this to the 1.x Backlog milestone Oct 28, 2018
@bbondy bbondy added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 28, 2018
@NejcZdovc
Copy link
Contributor

@jenn-rhim images are sadly not working when I run it through our process defined here https://github.com/brave/brave-ui/wiki/How-to-handle-icons. Can you please update them? Thank you

image

@btlechowski
Copy link

btlechowski commented Jan 18, 2019

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

Icons in rewards welcome page
image

Icons in rewards settings page were not update: #3013

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

image

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

screen shot 2019-01-23 at 3 52 53 pm

@ryanml
Copy link
Contributor

ryanml commented Jan 18, 2019

See comment regarding this here: #3013 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants