Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme for request ads enabled popup #18525

Closed
aseren opened this issue Oct 4, 2021 · 1 comment · Fixed by brave/brave-core#10383
Closed

Dark theme for request ads enabled popup #18525

aseren opened this issue Oct 4, 2021 · 1 comment · Fixed by brave/brave-core#10383
Assignees
@aseren
Labels
2_point For Agile sizing feature/ads feature/brave-talk OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.32.x - Release

Comments

@aseren
Copy link

aseren commented Oct 4, 2021

Need to support dark theme for popup that is triggered by chrome.braveRequestAdsEnabled api.
@aseren aseren self-assigned this Oct 4, 2021
@jsecretan jsecretan added the 2_point For Agile sizing label Oct 5, 2021
aseren added a commit to brave/brave-core that referenced this issue Oct 6, 2021
@aseren
Dark theme for brave talk opt-in popup.
527c5b4 
fix brave/brave-browser#18525
@aseren aseren mentioned this issue Oct 6, 2021
Merged
24 tasks
tmancey pushed a commit to brave/brave-core that referenced this issue Oct 7, 2021
@aseren @tmancey
Dark theme for brave talk opt-in popup.
a579120 
fix brave/brave-browser#18525
@aseren aseren added this to the 1.32.x - Nightly milestone Oct 11, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.32.63 Chromium: 95.0.4638.40 (Official Build) nightly (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave with --enable-features=RequestAdsEnabledApi
  3. set Brave colors to Dark via brave://settings/appearance
  4. loaded talk.bravesoftware.com
  5. clicked on the Start free 1:1 call button
  6. confirmed that the popup was dark-themed
  7. changed Brave colors to Light and same as macOS, and confirmed the popup was light-themed again
example example example example example example
Screen Shot 2021-10-11 at 5 04 54 PM Screen Shot 2021-10-11 at 4 57 41 PM Screen Shot 2021-10-11 at 5 06 55 PM Screen Shot 2021-10-11 at 5 04 48 PM Screen Shot 2021-10-11 at 5 04 43 PM Screen Shot 2021-10-11 at 5 00 39 PM

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
2_point For Agile sizing feature/ads feature/brave-talk OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

Dark theme for brave talk opt-in popup. brave/brave-core
3 participants
@jsecretan @stephendonner @aseren