Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the Later button from the second adaptive captcha notification/modal #19056

Closed
kjozwiak opened this issue Oct 28, 2021 · 5 comments · Fixed by brave/brave-core#11016
Closed

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Oct 28, 2021

Description

We should remove the Later button from the second notification/modal. Or at least make it look disabled/unclickable. With the current implementation, a enabled/disabled Later button looks exactly the same which might lead to confusion/support issues regarding why the Later button isn't clickable.

More information/screenshots can be found via https://github.com/brave/internal/issues/769.

Steps to Reproduce

  1. https://github.com/brave/internal/issues/769#issuecomment-946388708

Actual result:

Later button on the second notification isn't clickable and appears broken.

Expected result:

We should either make it appear as disabled or remove it entirely.

Reproduces how often:

100% reproducible using the STR/Cases mentioned above.

Brave version (brave://version info)

Brave | 1.33.34 Chromium: 95.0.4638.54 (Official Build) nightly (64-bit)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | Windows 11 Version 21H2 (Build 22000.258)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @emerick @jsecretan @rebron @brave/legacy_qa

@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 10, 2021
@kjozwiak kjozwiak changed the title remove the Learn more button from the second adaptive captcha notification/modal remove the Later button from the second adaptive captcha notification/modal Nov 10, 2021
@emerick emerick self-assigned this Nov 11, 2021
@emerick
Copy link
Contributor

emerick commented Nov 11, 2021

We'll remove the button when snooze is no longer allowed (i.e., after the first snooze).

@stephendonner
Copy link

stephendonner commented Dec 15, 2021

Verified PASSED using

Brave 1.34.63 Chromium: 96.0.4664.110 (Official Build) beta (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Windows 10 Version 20H2 (Build 19042.1415)

Steps:

  1. new profile
  2. launched Brave against Rewards staging
  3. enabled Rewards
  4. drove down unblinded tokens
  5. issued an aCAPTCHA challenge using curl against the staging endpoint
  6. confirmed I saw the 1st aCAPTCHA, with Solve and Later buttons
  7. restarted the browser
  8. drove down unblinded tokens again
  9. issued another aCAPTCHA challenge
  10. confirmed 2nd aCAPTCHA dialog only had a Solve button
1st aCAPTCHA 2nd aCAPTCHA
19056-1 19056-2

Verification passed on

Brave 1.34.63 Chromium: 96.0.4664.110 (Official Build) beta (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Ubuntu 18.04 LTS

Verified Later button is gone on 2nd captcha
Verified was able to solve the captcha after clicking Solve

image image

@stephendonner
Copy link

NOTE: clicking on Solve in the 2nd aCAPTCHA dialog doesn't trigger the solve-challenge dialog. Will file and circle back.

@stephendonner
Copy link

NOTE: clicking on Solve in the 2nd aCAPTCHA dialog doesn't trigger the solve-challenge dialog. Will file and circle back.

Filed #20121.

@stephendonner
Copy link

Verified PASSED on macOS using

Brave 1.34.66 Chromium: 96.0.4664.110 (Official Build) beta (x86_64)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS macOS Version 11.6.1 (Build 20G224)

Followed the steps above, and confirmed the 2nd dialog no longer has the Later button.

Also, confirmed (just as a datapoint) that I got the aCAPTCHA when clicking on Solve.

example example example
Screen Shot 2021-12-17 at 11 21 20 AM Screen Shot 2021-12-17 at 11 22 54 AM Screen Shot 2021-12-17 at 11 23 01 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment