Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Later button in adaptive captcha notification instead of disabli… #11016

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Nov 11, 2021

Resolves brave/brave-browser#19056

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Via STR in https://github.com/brave/internal/issues/769#issuecomment-946388708

@emerick emerick self-assigned this Nov 11, 2021
@emerick emerick force-pushed the rewards-hide-captcha-notification-later-button branch from c5d6e13 to 900bbb5 Compare November 12, 2021 04:25
@emerick emerick merged commit 7b19277 into master Nov 12, 2021
@emerick emerick deleted the rewards-hide-captcha-notification-later-button branch November 12, 2021 21:45
@emerick emerick added this to the 1.34.x - Nightly milestone Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove the Later button from the second adaptive captcha notification/modal
2 participants