Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NTP Background Images component for Fall 2021 wallpapers on desktop #19129

Closed
Tracked by #18568
simonhong opened this issue Nov 1, 2021 · 2 comments
Closed
Tracked by #18568

Comments

@simonhong
Copy link
Member

simonhong commented Nov 1, 2021

This is sub-task of #18568 for updating NTP Background images component

Test plan:

  1. Launch browser and wait NTP Background Component is upated to 1.0.4 version
  2. Check NTP shows all new set of BG images described in the description of NTP Fall 2021 wallpapers #18568
@simonhong
Copy link
Member Author

@simonhong simonhong added this to the 1.33.x - Nightly milestone Nov 2, 2021
@simonhong simonhong removed the OS/Android Fixes related to Android browser functionality label Nov 2, 2021
@simonhong simonhong changed the title Update NTP Background Images component for Fall 2021 wallpapers Update NTP Background Images component for Fall 2021 wallpapers on desktop Nov 2, 2021
@stephendonner
Copy link

stephendonner commented Nov 2, 2021

Verified PASSED using

Brave 1.33.51 Chromium: 95.0.4638.69 (Official Build) nightly (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. launched Brave
  3. loaded brave://components
  4. confirmed Version: 1.0.4 of NTP Background Images
Screen Shot 2021-11-02 at 9 09 45 AM
  1. cycled through each new-tab page, noting the background images
  2. confirmed they were (15) new images which match those in NTP Fall 2021 wallpapers #18568
Screen Shot 2021-11-02 at 9 29 31 AM Screen Shot 2021-11-02 at 9 29 35 AM Screen Shot 2021-11-02 at 9 29 37 AM Screen Shot 2021-11-02 at 9 29 39 AM Screen Shot 2021-11-02 at 9 29 43 AM
Screen Shot 2021-11-02 at 9 29 45 AM Screen Shot 2021-11-02 at 9 29 47 AM Screen Shot 2021-11-02 at 9 29 52 AM Screen Shot 2021-11-02 at 9 29 56 AM Screen Shot 2021-11-02 at 9 29 58 AM
Screen Shot 2021-11-02 at 9 30 03 AM Screen Shot 2021-11-02 at 9 30 05 AM Screen Shot 2021-11-02 at 9 30 08 AM Screen Shot 2021-11-02 at 9 30 13 AM Screen Shot 2021-11-02 at 9 30 16 AM

Verified PASSED using

Brave 1.33.82 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 20H2 (Build 19042.1348)

Steps:

  1. new profile
  2. launched Brave
  3. loaded brave://components
  4. confirmed Version: 1.0.4 of NTP Background Images

19129-1

  1. cycled through each new-tab page, noting the background images
  2. confirmed they were (15) new images which match those in NTP Fall 2021 wallpapers #18568
19129-2 19129-3 19129-4 19129-5 19129-6
19129-8 19129-9 19129-10 19129-11 19129-12
19129-13 19129-14 19129-15 19129-16 19129-17

Verified PASSED using

Brave 1.33.85 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Steps:

  1. new profile
  2. launched Brave
  3. loaded brave://components
  4. confirmed Version: 1.0.4 of NTP Background Images
Screen Shot 2021-11-19 at 6 59 17 PM
  1. cycled through each new-tab page, noting the background images
  2. confirmed they were (15) new images which match those in NTP Fall 2021 wallpapers #18568
Screen Shot 2021-11-19 at 7 00 28 PM Screen Shot 2021-11-19 at 7 00 38 PM Screen Shot 2021-11-19 at 7 00 43 PM Screen Shot 2021-11-19 at 7 00 57 PM Screen Shot 2021-11-19 at 7 01 03 PM
Screen Shot 2021-11-19 at 7 01 07 PM Screen Shot 2021-11-19 at 7 01 15 PM Screen Shot 2021-11-19 at 7 01 18 PM Screen Shot 2021-11-19 at 7 01 21 PM Screen Shot 2021-11-19 at 7 01 27 PM
Screen Shot 2021-11-19 at 7 01 31 PM Screen Shot 2021-11-19 at 7 01 41 PM Screen Shot 2021-11-19 at 7 01 47 PM Screen Shot 2021-11-19 at 7 01 51 PM Screen Shot 2021-11-19 at 7 01 55 PM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment