Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default NTP wallpaper on Desktop #19127

Closed
Tracked by #18568
simonhong opened this issue Nov 1, 2021 · 2 comments · Fixed by brave/brave-core#10790
Closed
Tracked by #18568

Update default NTP wallpaper on Desktop #19127

simonhong opened this issue Nov 1, 2021 · 2 comments · Fixed by brave/brave-core#10790

Comments

@simonhong
Copy link
Member

simonhong commented Nov 1, 2021

This is sub task of #18568 for replacing default bg image on Desktop.

STR:

  1. Launch browser with clean profile
  2. Open NTP and check Dylan Malval's image is displayed till NTP Background Images component is loaded.
@simonhong simonhong self-assigned this Nov 1, 2021
@simonhong simonhong changed the title Update NTP Fall 2021 wallpapers on Desktop Update default NTP wallpaper on Desktop Nov 1, 2021
simonhong added a commit to brave/brave-core that referenced this issue Nov 1, 2021
@simonhong simonhong added this to the 1.33.x - Nightly milestone Nov 2, 2021
@stephendonner
Copy link

stephendonner commented Nov 2, 2021

Verified PASSED using

Brave 1.33.52 Chromium: 95.0.4638.69 (Official Build) nightly (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. disconnected from Wi-Fi
  2. new profile
  3. launched Brave
  4. opened a new-tab page
  5. confirmed the image is Dylan Malval's
  6. opened a few more new-tab pages
  7. confirmed the image is still Dylan Malval's
  8. reconnected to Wi-Fi
  9. loaded brave://components and saw the NTP Background Images downloaded version 1.0.4
  10. confirmed after enabling Wi-Fi that subsequent new-tab page loads brought in additional images
example example example example
Screen Shot 2021-11-02 at 11 18 43 AM Screen Shot 2021-11-02 at 11 23 21 AM Screen Shot 2021-11-02 at 11 19 36 AM Screen Shot 2021-11-02 at 11 25 55 AM

Verified PASSED using

Brave 1.33.82 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 20H2 (Build 19042.1348)

Steps:

  1. disconnected from Wi-Fi
  2. new profile
  3. launched Brave
  4. opened a new-tab page
  5. confirmed the image is Dylan Malval's
  6. opened a few more new-tab pages
  7. confirmed the image is still Dylan Malval's
  8. reconnected to Wi-Fi
  9. loaded brave://components and saw the NTP Background Images downloaded version 1.0.4
  10. confirmed after enabling Wi-Fi that subsequent new-tab page loads brought in additional images
example example example
19127-1 19127-2 19127-3

Verified PASSED using

Brave 1.33.82 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 20H2 (Build 19042.1348)

Steps:

  1. disconnected from Wi-Fi
  2. new profile
  3. launched Brave
  4. opened a new-tab page
  5. confirmed the image is Dylan Malval's
  6. opened a few more new-tab pages
  7. confirmed the image is still Dylan Malval's
  8. reconnected to Wi-Fi
  9. loaded brave://components and saw the NTP Background Images downloaded version 1.0.4
  10. confirmed after enabling Wi-Fi that subsequent new-tab page loads brought in additional images
example example example
Screen Shot 2021-11-19 at 7 27 19 PM Screen Shot 2021-11-19 at 7 25 35 PM Screen Shot 2021-11-19 at 7 26 29 PM

@LaurenWags
Copy link
Member

@brave/legacy_qa this can be tested along side #19129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment