Crash from Play Console on welcome screen

[SergeyZhukovsky]

Description

I could not replicate that crash but tried to fix it following that crash stack:

java.lang.IndexOutOfBoundsException: 
  at android.text.SpannableStringInternal.checkRange (SpannableStringInternal.java:490)
  at android.text.SpannableStringInternal.setSpan (SpannableStringInternal.java:196)
  at android.text.SpannableStringInternal.setSpan (SpannableStringInternal.java:183)
  at android.text.SpannableString.setSpan (SpannableString.java:60)
  at org.chromium.chrome.browser.firstrun.P3aOnboardingActivity.initializeViews (P3aOnboardingActivity.java:106)
  at org.chromium.chrome.browser.firstrun.P3aOnboardingActivity.access$100 (P3aOnboardingActivity.java:39)
  at org.chromium.chrome.browser.firstrun.P3aOnboardingActivity$4.onFlowIsKnown (P3aOnboardingActivity.java:170)
  at org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer.processFreEnvironmentPreNative (FirstRunFlowSequencer.java:146)
  at org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer.lambda$start$0 (FirstRunFlowSequencer.java:80)
  at org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer$$InternalSyntheticLambda$2$e9f9023b24e0ae00a394c9d2a0b24349cfa914e82d07a383ccf4417e7ef1b845$0.onStatusReady (FirstRunFlowSequencer.java)
  at org.chromium.chrome.browser.childaccounts.ChildAccountService.checkChildAccountStatus (ChildAccountService.java:70)
  at org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer.lambda$start$1 (FirstRunFlowSequencer.java:76)
  at org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer$$InternalSyntheticLambda$1$0d37986862a2b58d8af9e8bfc5609deeebb2c15954259479f2a48f98f545a52e$0.onResult (FirstRunFlowSequencer.java)
  at org.chromium.base.Callback.lambda$bind$0 (Callback.java:30)
  at org.chromium.base.Callback.$r8$lambda$wNfPpCy4eZZTA1F_MOQzlsimv7g (Callback.java)
  at org.chromium.base.Callback$$InternalSyntheticLambda$0$3858224dc26aab9b59a2b853862cedd27d4b14f1de3e591812291cb3c86b74d7$0.run (Callback.java:4)
  at android.os.Handler.handleCallback (Handler.java:883)
  at android.os.Handler.dispatchMessage (Handler.java:100)
  at android.os.Looper.loop (Looper.java:237)
  at android.app.ActivityThread.main (ActivityThread.java:7948)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1075)

Steps to reproduce

What I think as it's related to some locales, I tried diff languages looking on reviews from people, but everything works as expected.

Actual result

Make sure that text private product analytics is clickable and there is no crash on that screen

Expected result

Issue reproduces how often

no steps to reproduce

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version?
• Can you reproduce this issue with the current Play Store Beta version?
• Can you reproduce this issue with the current Play Store Nightly version?

Device details

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Brave version

Website problems only

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Additional information

[kjozwiak]

@brave/legacy_qa re: STR/Cases, as per @SergeyZhukovsky comment above, lets go through the on-boarding screen on several locales and make sure that the private product analytics string is clickable and doesn't cause any issues.

[kjozwiak]

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.31.90 Chromium: 95.0.4638.69

As per the STR/Cases mentioned via #19135 (comment), ensured that Brave doesn't crash when tapping on private product analytics via the following locales:

• Poland, Russia, Germany & English

Also ensured that tapping on private product analytics while there's no network connection doesn't cause any issues.

---

Verification passed on Oppo Reno 5 with Android 11 running 1.31.90 x64 build

• Verified no crash when selecting private product analytics from welcome screen
• Verified on French/German/Japanese locales

---

Verification PASSED on Samsung Galaxy Tablet A running Android 11 using the following build:

1.31.90 Chromium: 95.0.4638.69

As per the STR/Cases mentioned via #19135 (comment), ensured that Brave doesn't crash when tapping on private product analytics via the following locales:

• Italy, Spain, Netherlands & English

Also ensured that tapping on private product analytics while there's no network connection doesn't cause any issues.