Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad earnings "Claim buttons" cannot be clicked and are unresponsive #19211

Closed
Miyayes opened this issue Nov 3, 2021 · 5 comments · Fixed by brave/brave-core#11118
Closed

Ad earnings "Claim buttons" cannot be clicked and are unresponsive #19211

Miyayes opened this issue Nov 3, 2021 · 5 comments · Fixed by brave/brave-core#11118
Labels
feature/rewards OS/Desktop payouts priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.34.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Nov 3, 2021

Description

Report from users: https://reddit.com/r/brave_browser/comments/qjp91a/the_claim_buttons_cannot_be_pressed_is_this_normal/

image

I asked if their wallets were corrupted (i.e., whether rewards-internals was reporting "Wallet not yet created"), and unanimously the answer was no (not corrupted).
@Miyayes Miyayes added the needs-investigation A bug not 100% confirmed/fixed label Nov 3, 2021
@zenparsing
Copy link

zenparsing commented Nov 3, 2021 •
edited
Loading

@Miyayes I was able to reproduce by enabling the "Hide Brave Rewards button" setting. Similar to #19163.

@Miyayes
Copy link
Collaborator Author

Miyayes commented Nov 5, 2021

The user confirmed that unhiding the BAT icon resolves this issue.

@Miyayes Miyayes added payouts and removed needs-investigation A bug not 100% confirmed/fixed labels Nov 5, 2021
@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Nov 10, 2021
@Miyayes Miyayes mentioned this issue Nov 15, 2021
Closed
@zenparsing zenparsing mentioned this issue Nov 17, 2021
Merged
24 tasks
@zenparsing zenparsing added this to the 1.34.x - Nightly milestone Nov 30, 2021
@LaurenWags
Copy link
Member

Labelling QA/Blocked as this is pending a test plan per brave/brave-core#11118 (comment)

@LaurenWags LaurenWags added QA/Test-All-Platforms QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Blocked labels Dec 15, 2021
@LaurenWags
Copy link
Member

LaurenWags commented Dec 16, 2021 •
edited by btlechowski
Loading

Verified using

Brave	1.34.64 Chromium: 96.0.4664.110 (Official Build) beta (x86_64)
Revision	d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS	macOS Version 11.6.1 (Build 20G224)

Verified test plan from brave/brave-core#11118

Scenario 1 - Claim single ad grant from brave://rewards - PASSED
  1. With Rewards enabled, enabled "Hide Brave Rewards icon" setting from brave://settings/appearance
  2. Asked Chris to send a single Ad grant, waited a bit
  3. Navigated to brave://rewards
  4. Confirmed able to click on "Claim" button for the ad grant
  5. Confirmed BAT logo displayed and panel opened to show CAPTCHA
  6. Confirmed CAPTCHA could be solved successfully
  7. Confirmed when the panel is closed, the BAT logo is hidden
Step 4 Step 5 Step 6 Step 7
4 5 6 7
Scenario 2 - Claim single ad grant from NTP widget - PASSED
  1. With Rewards enabled, enabled "Hide Brave Rewards icon" setting from brave://settings/appearance
  2. Asked Chris to send a single Ad grant, waited a bit
  3. Navigated to NTP (may need to cancel out of UGP notification on widget if you have not done so yet)
  4. Confirmed able to click on "Claim earnings" button for the ad grant from widget
  5. Confirmed BAT logo displayed and panel opened to show CAPTCHA
  6. Confirmed CAPTCHA could be solved successfully
  7. Confirmed when the panel is closed, the BAT logo is hidden
Step 4 Step 5 Step 6 Step 7
4 5 6 7
Scenario 3 - Claim multiple ad grants from brave://rewards - PASSED
  1. With Rewards enabled, enabled "Hide Brave Rewards icon" setting from brave://settings/appearance
  2. Asked Chris to send a few Ad grants, waited a bit
  3. Navigated to brave://rewards page
  4. Confirmed able to click on "Claim earnings" button for each ad grant
  5. Confirmed BAT logo displayed and panel opened to show CAPTCHA for each ad grant
  6. Confirmed CAPTCHA could be solved successfully for each ad grant
  7. Confirmed when the panel is closed, the BAT logo is hidden for each ad grant
Step 4 Step 5 Step 6 Step 7
4a 5a 6a 7a
4b 5b 6b 7b
4c 5c 6c 7c
Scenario 4 - Claim multiple ad grants from NTP widget - PASSED
  1. With Rewards enabled, enabled "Hide Brave Rewards icon" setting from brave://settings/appearance
  2. Asked Chris to send a few Ad grants, waited a bit
  3. Navigated to NTP (may need to cancel out of UGP notification on widget if you have not done so yet)
  4. Confirmed able to click on "Claim earnings" button for each ad grant
  5. Confirmed BAT logo displayed and panel opened to show CAPTCHA for each ad grant
  6. Confirmed CAPTCHA could be solved successfully for each ad grant
  7. Confirmed when the panel is closed, the BAT logo is hidden for each ad grant
Step 4 Step 5 Step 6 Step 7
4a 5a 6a 7a
4b 5b 6b 7b
4c 5c 6c 7c
Scenario 5 - Claim ugp grant from brave://rewards - PASSED
  1. With Rewards enabled, enabled "Hide Brave Rewards icon" setting from brave://settings/appearance
  2. Navigated to brave://rewards
  3. Confirmed able to click on "Claim" button for ugp grant
  4. Confirmed BAT logo displayed and panel opened to show CAPTCHA for ugp grant
  5. Confirmed CAPTCHA could be solved successfully for ugp grant
  6. Confirmed when the panel is closed, the BAT logo is hidden for ugp grant
Step 3 Step 4 Step 5 Step 6
4 5 6 7
Scenario 6 - Claim ugp grant from NTP widget - PASSED
  1. With Rewards enabled, enabled "Hide Brave Rewards icon" setting from brave://settings/appearance
  2. Navigated to NTP
  3. Confirmed able to click on "Claim" button for ugp grant
  4. Confirmed BAT logo displayed and panel opened to show CAPTCHA for ugp grant
  5. Confirmed CAPTCHA could be solved successfully for ugp grant
  6. Confirmed when the panel is closed, the BAT logo is hidden for ugp grant
Step 3 Step 4 Step 5 Step 6
3 4 5 6

Verified PASSED using

Brave 1.34.68 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 10 Version 20H2 (Build 19042.1415)

Verified test plan from brave/brave-core#11118

Scenario 1 - Claim single ad grant from brave://rewards - PASSED
  1. With Rewards enabled, enabled "Hide Brave Rewards icon" setting from brave://settings/appearance
  2. Asked Chris to send a single Ad grant, waited a bit
  3. Navigated to brave://rewards
  4. Confirmed able to click on "Claim" button for the ad grant
  5. Confirmed BAT logo displayed and panel opened to show CAPTCHA
  6. Confirmed CAPTCHA could be solved successfully
  7. Confirmed when the panel is closed, the BAT logo is hidden
Step 4 Step 5 Step 6 Step 7 Step 7, part 2
rewards-step4 rewards-step5 rewards-step6 rewards-step8 rewards-step7
Scenario 2 - Claim single ad grant from NTP widget - PASSED
  1. With Rewards enabled, enabled "Hide Brave Rewards icon" setting from brave://settings/appearance
  2. Asked Chris to send a single Ad grant, waited a bit
  3. Navigated to NTP (may need to cancel out of UGP notification on widget if you have not done so yet)
  4. Confirmed able to click on "Claim earnings" button for the ad grant from widget
  5. Confirmed BAT logo displayed and panel opened to show CAPTCHA
  6. Confirmed CAPTCHA could be solved successfully
  7. Confirmed when the panel is closed, the BAT logo is hidden
Step 4 Step 5 Step 6 Step 7
ntp-step-4 ntp-step-5 ntp-step-6 ntp-step-7

Verification passed on

Brave 1.34.67 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#11118

Scenario 1 - Claim single ad grant from brave://rewards - PASSED

image
image
image
image
image
image

Scenario 2 - Claim single ad grant from NTP widget - PASSED

image
image
image
image

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 16, 2021
@stephendonner
Copy link

@brave/legacy_qa: per Slack convo, we only need to do scenarios 1 & 2 on all platforms: https://bravesoftware.slack.com/archives/GAA4017R7/p1639667016124800

@Miyayes Miyayes mentioned this issue Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/rewards OS/Desktop payouts priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Display the rewards icon when the rewards panel is requested brave/brave-core
5 participants
@stephendonner @zenparsing @Miyayes @LaurenWags @btlechowski