Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the rewards icon when the rewards panel is requested #11118

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Nov 16, 2021

Resolves brave/brave-browser#19211

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Scenario: Claim button on Rewards page should work when the user has chosen to hide the Rewards icon

  • Given that the user has enabled the "Hide Brave Rewards icon" setting on brave://settings
  • And the user has an available grant
  • When the user clicks the "Claim" button on the Rewards page
  • Then the Rewards panel should open
  • And allow the user to solve the grant captcha

Scenario: Claim button on new tab page should work when the user has chosen to hide the Rewards icon

  • Given that the user has enabled the "Hide Brave Rewards icon" setting on brave://settings
  • And the user has an available grant
  • When the user clicks the "Claim" button on the new tab page
  • Then the Rewards panel should open
  • And allow the user to solve the grant captcha

Scenario: The Rewards icon should be hidden after the panel is closed when the user has chosen to hide the Rewards icon

  • Given that the user has enabled the "Hide Brave Rewards icon" setting on brave://settings
  • And the user has opened the Rewards panel to claim a grant
  • When the user closes the panel
  • Then the Rewards icon should be hidden

@zenparsing zenparsing marked this pull request as ready for review November 17, 2021 22:10
@zenparsing zenparsing force-pushed the ksmith-rewards-button-fixes branch 2 times, most recently from c2ca3ce to 7d1e87b Compare November 24, 2021 14:54
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ with some comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ad earnings "Claim buttons" cannot be clicked and are unresponsive
3 participants