Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show active transactions and token balances in the panel #19533

Closed
bbondy opened this issue Nov 17, 2021 · 2 comments · Fixed by brave/brave-core#11655
Closed

Show active transactions and token balances in the panel #19533

bbondy opened this issue Nov 17, 2021 · 2 comments · Fixed by brave/brave-core#11655
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented Nov 17, 2021

It'd be nice to see any active and recent transactions directly in the wallet panel. Users feel like they have to dig to get to them now in brave://wallet.

Users would also like to see asset balances easily in the panel.

@bbondy bbondy added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 17, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 17, 2021
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 22, 2021
@bbondy bbondy changed the title Show active transactions in the panel Show active transactions and token balances in the panel Nov 22, 2021
@Douglashdaniel Douglashdaniel self-assigned this Dec 15, 2021
@Douglashdaniel Douglashdaniel added this to the 1.35.x - Nightly milestone Dec 21, 2021
@srirambv
Copy link
Contributor

Android specific implementation #20765
iOS specific implementation brave/brave-ios#4912

Removing Android label from the issue as Android specific issue is logged

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Jan 28, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 1, 2022

Brave 1.35.98 Chromium: 98.0.4758.72 (Official Build) (64-bit)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11655
  • Verified panel has a new Lightning boltbutton next to swap
  • Verified clicking on the Lightning boltbutton shows the recent transactions
  • Verified able to click individually listed transaction to see transaction details
  • Verified able to submit Speedup or Cancel from the panel itself
  • Verified transaction status's displays Value, Transaction fee, Date, Network and Status
  • Verified Submitted, Confirmed transactions provide hash which links to the block explorer for that transaction
19533-Linux.mp4
19533-Windows.mov
19533-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants