Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Transactions in Wallet Panel #11655

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Dec 20, 2021

Description

Introducing transactions in the Brave Wallet Panel

  1. New Lightning Bolt button at the bottom right of the panel will nav you to the Recent Transactions panel
  2. Recent Transactions panel will display a list of all your recent transactions, clicking on a transaction will nav you to the Transaction Details panel
  3. Transaction Details panel will give you various information depending on the type/status of transaction.
  • All transaction status's will display Value, Transaction fee, Date, Network and Status
  • All none Rejected and Unapproved transactions will display a Transaction hash that is linked to Block Explorers
  • Submitted and Approved transactions will display Cancel and Speedup transactions buttons
  • Error transactions will display a Retry Transaction button.

note: (Token balances mentioned in the issue will be handled in a separate PR here brave/brave-browser#20179)

Resolves brave/brave-browser#19533

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2021-12-20.at.1.02.59.PM.mov

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show active transactions and token balances in the panel
2 participants