Changes to sync QR code

[bsclifton]

Description:

See https://github.com/brave/internal/issues/832

[LaurenWags]

QA/Blocked until uplifted to 1.33.x

[AlexeyBarabash]

Verified on https://github.com/brave/brave-browser/releases/tag/v1.35.1, preparing uplift to 1.33.x

[AlexeyBarabash]

Uplift PR created brave/brave-core#11358

[LaurenWags]

Removing QA/Blocked as 1.33.99 is available

[stephendonner]

Verified PASSED using

Brave	1.33.101 Chromium: 96.0.4664.93 (Official Build) (x86_64)
Revision	17531e0a70b4f8108f2418e8b5117f465077710b-refs/branch-heads/4664@{#1229}
OS	macOS Version 11.6.1 (Build 20G224)

Cross-timezone tests - PASSED

1. set up a desktop on the Los Angeles timezone
2. set up an Android phone on the Auckland (NZ) timezone.
3. create a Sync chain on Desktop
4. attempt to join the Sync chain on Android (it should WORK)
5. reset both browser profiles.
6. change desktop computer to the Auckland (NZ) timezone.
7. change Android phone to the Los Angeles timezone.
8. create Sync chain on Desktop.
9. attempt to join the Sync chain on Android (it should WORK)
10. repeat these steps with two Android phones and no Desktop.
    1. unable to test; only have a single Android test device
11. repeat these steps with a Desktop and an iOS phone
12. repeat these steps with an iOS phone as the Sync chain creator and an Android phone as the Sync chain joiner

Desktop & Android - PASSED

example	example	example	example
	[image missing; corrupted while uploading to GitHub. Not retesting for sake of time.]

Desktop & iOS - PASSED

example	example	example	example	example	example

iOS & Android - PASSED

example	example	example	example	example	example

Normal expiration test - PASSED

1. create a Sync chain on Desktop and keep it open until Step 6 is done.
2. wait 20 minutes.
3. attempt to join Sync chain on Android (it should WORK).
4. reset Android profile.
5. wait 11 minutes (so that it’s > 30 minutes since generating the code).
6. attempt to join Sync chain on Android (it should FAIL)
7. repeat these steps with two Android phones and no Desktop (NOTE: unable to test; only have a single Android test device)
8. repeat these steps with a Desktop and an iOS phone.
9. repeat these steps with an iOS phone as the Sync chain creator and an Android phone as the Sync chain joiner

Desktop & Android - PASSED

example	example	example

Desktop & iOS - PASSED

example	example	example

iOS & Android - PASSED

Verification done over in #19550 (comment)

Code expiring too far into the future - PASSED

1. set up a desktop computer and change the date to 1 day into the future.
2. set up an Android phone with the correct date and time.
3. create a Sync chain on Desktop.
4. attempt to join the Sync chain on Android (it should FAIL)
5. attempt to join the same Sync chain on iOS (it should FAIL)

example	example	example

Old-style QR codes - PASSED

1. set up a desktop computer with an earlier version of Brave (with the old-style QR codes).
2. set up an Android phone with support for updated QR codes.
3. create a Sync chain on Desktop.
4. attempt to join the Sync chain on Android (it should WORK).
5. reset both browser profiles.
6. change time on desktop computer to January 2nd 2022.
7. change time on Android phone to January 2nd 2022.
8. create a Sync chain on Desktop.
9. attempt to join the Sync chain on Android (it should FAIL).
10. repeat these steps with an iOS phone instead of an Android one.

Desktop & Android - PASSED

example	example	example	example

Desktop & iOS - PASSED

example	example	example	example

Malformed QR codes (Android & desktop) - PASSED

malformed JSON	unsupported version (too small)	unsupported version (too recent)	sync_code_hex (too short)	sync_code_hex (too long)	sync_code_hex (invalid hex)	missing sync_code_hex	missing version	missing expirary

malformed JSON	unsupported version (too small)	unsupported version (too recent)	sync_code_hex (too short)	sync_code_hex (too long)	sync_code_hex (invalid hex)	missing sync_code_hex	missing version	missing expirary

[LaurenWags]

Verified using 1.33.100 on the below two devices for Android <--> Android tests.

Android 1 - Google Pixel (Android 11)
Android 2 - Samsung JNeo (Android 7)

Verified cases listed in doc from https://github.com/brave/internal/issues/832#issuecomment-973471650 for Android <--> Android sync.

Cross-timezone tests - PASSED

1. Setup Android 1 on the Los Angeles timezone.
2. Setup Android 2 on the Auckland (NZ) timezone.
3. Create a Sync chain on Android 1.
4. Attempt to join the Sync chain on Android 2 (it should WORK).
5. Reset both Android profiles.
6. Create Sync chain on Android 2.
7. Attempt to join the Sync chain on Android 1 (it should WORK).

Confirmed able to join sync chains as expected in steps 4 and 7.

Android 1 - LA	Android 2 - Auckland

Step 3	Step 4

Step 6	Step 7

Normal expiration test - PASSED

1. Create a Sync chain on Android 1 and keep it open until Step 6 is done.
2. Wait 20 minutes.
3. Attempt to join Sync chain on Android 2 (it should WORK).
4. Reset Android 2 profile.
5. Wait 11 minutes (so that it’s > 30 minutes since generating the code).
6. Attempt to join Sync chain on Android 2 (it should FAIL).

Step 1	Step 3	Step 6

Code expiring too far into the future - PASSED

1. Setup Android 1 and change the date to 1 day into the future.
2. Setup Android 2 with the correct date and time.
3. Create a Sync chain on Android 1.
4. Attempt to join the Sync chain on Android 2 (it should FAIL).

Step 1 - Android 1	Step 2 - Android 2	Step 3	Step 4

Old-style QR codes - PASSED

1. Setup Android 1 with an earlier version of Brave (with the old-style QR codes).
2. Setup Android 2 phone with support for updated QR codes.
3. Create a Sync chain on Android 1.
4. Attempt to join the Sync chain on Android 2 (it should WORK).
5. Reset both browser profiles.
6. Change time on Android 1 to January 2nd 2022.
7. Change time on Android 2 to January 2nd 2022.
8. Create a Sync chain on Android 1.
9. Attempt to join the Sync chain on Android 2 (it should FAIL).

Step 1 - Android 1	Step 2 - Android 2	Step 4 Android 1	Step 4 Android 2	Step 6	Step 7	Step 9

Note - Malformed QR Codes were tested on Android by @stephendonner with #19550 (comment).

---

Verified using 1.33 (21.12.7.21) on the below two devices for iOS <--> iOS tests.

iOS 1 - iPhone 6s Plus (iOS 15.1)
iOS 2 - iPad 5th Gen (iOS 14.8.1)

Verified cases listed in doc from https://github.com/brave/internal/issues/832#issuecomment-973471650 for iOS <--> iOS sync.

Cross-timezone tests - PASSED

1. Setup iOS 1 on the Los Angeles timezone.
2. Setup iOS 2 on the Auckland (NZ) timezone.
3. Create a Sync chain on iOS 1.
4. Attempt to join the Sync chain on iOS 2 (it should WORK).
5. Reset both iOS profiles.
6. Create Sync chain on iOS 2.
7. Attempt to join the Sync chain on iOS 1 (it should WORK).

Initially to join sync chains as expected in steps 4 and 7, logged brave/brave-ios#4662.
However, restarting the device after re-setting the timezone worked and allowed the test to pass.

iOS 1 - LA	iOS 2 - Auckland

Step 3	Step 4

Step 6	Step 7

Normal expiration test - PASSED

1. Create a Sync chain on iOS 1 and keep it open until Step 6 is done.
2. Wait 20 minutes.
3. Attempt to join Sync chain on iOS 2 (it should WORK).
4. Reset iOS 2 profile.
5. Wait 11 minutes (so that it’s > 30 minutes since generating the code).
6. Attempt to join Sync chain on iOS 2 (it should FAIL).

Step 1	Step 3	Step 6

Code expiring too far into the future - PASSED

1. Create a Sync chain on iOS 1.
2. Close and exit the app fully (remove from memory)
3. Setup iOS 1 to the date to 1 day into the future. (Close settings fully/remove from memory and relaunch to confirm the time change took effect as expected)
4. Setup iOS 2 with the correct date and time.
5. Attempt to join the Sync chain on iOS 2 (it should FAIL).

Step 3 - iOS 1	Step 4 - iOS 2	Step 5

Old-style QR codes - PASSED

1. Setup iOS 1 with an earlier version of Brave (with the old-style QR codes).
2. Setup iOS 2 phone with support for updated QR codes.
3. Create a Sync chain on iOS 1.
4. Attempt to join the Sync chain on iOS 2 (it should WORK).
5. Reset both browser profiles.
6. Create a Sync chain on iOS 1 using an earlier version of Brave (with the old-style QR codes). Then close and exit Brave fully, removing from memory.
7. Install version with support for updated QR codes on iOS2 but do NOT join sync chain. Then close and exit Brave fully, removing from memory.
8. Change time on iOS 1 to January 2nd 2022. (Close settings fully/remove from memory and relaunch to confirm the date change took effect as expected)
9. Change time on iOS 2 to January 2nd 2022. (Close settings fully/remove from memory and relaunch to confirm the date change took effect as expected)
10. Attempt to join the Sync chain on iOS 2 (it should FAIL).

Step 1 - iOS 1	Step 2 - iOS 2	Step 4 iOS 1	Step 4 iOS 2	Step 8	Step 9	Step 10

Using 1.33 (21.12.8.23) with iPhone 6s Plus (iOS 15.1) for below tests:

Malformed QR codes/Malformed JSON (iOS) - PASSED

Scanned example Malformed QR Codes from spec, confirmed error message was received.

Malformed QR Code 1	Malformed QR Code 2

malformed JSON	unsupported version (too small)	unsupported version (too recent)	sync_code_hex (too short)	sync_code_hex (too long)	sync_code_hex (invalid hex)	missing sync_code_hex	missing version	missing expiry

malformed JSON	unsupported version (too small)	unsupported version (too recent)	sync_code_hex (too short)	sync_code_hex (too long)	sync_code_hex (invalid hex)	missing sync_code_hex	missing version	missing expiry

[stephendonner]

Verification PASSED using

[Brave	1.33.100 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision	38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS	Windows 10 Version 20H2 (Build 19042.1348)](#19550)

Cross-timezone tests - PASSED

1. set up a desktop on the Los Angeles timezone
2. set up an Android phone on the Auckland (NZ) timezone.
3. create a Sync chain on Desktop
4. attempt to join the Sync chain on Android (it should WORK)
5. reset both browser profiles.
6. change desktop computer to the Auckland (NZ) timezone.
7. change Android phone to the Los Angeles timezone.
8. create Sync chain on Desktop.
9. attempt to join the Sync chain on Android (it should WORK)
10. repeat these steps with two Android phones and no Desktop.
    1. unable to test; only have a single Android test device
11. repeat these steps with a Desktop and an iOS phone
12. repeat these steps with an iOS phone as the Sync chain creator and an Android phone as the Sync chain joiner

Desktop & Android - PASSED

example	example	example	example

Desktop & iOS - PASSED

example	example	example	example

iOS & Android - PASSED

example	example	example	example	example	example

Normal expiration test - PASSED

1. create a Sync chain on Desktop and keep it open until Step 6 is done.
2. wait 20 minutes.
3. attempt to join Sync chain on Android (it should WORK).
4. reset Android profile.
5. wait 11 minutes (so that it’s > 30 minutes since generating the code).
6. attempt to join Sync chain on Android (it should FAIL)
7. repeat these steps with two Android phones and no Desktop (NOTE: unable to test; only have a single Android test device)
8. repeat these steps with a Desktop and an iOS phone.
9. repeat these steps with an iOS phone as the Sync chain creator and an Android phone as the Sync chain joiner

Desktop & Android - PASSED

example	example	example

Desktop & iOS - PASSED

example	example	example

iOS & Android - PASSED

example	example	example	example

Code expiring too far into the future - PASSED

1. set up a desktop computer and change the date to 1 day into the future.
2. set up an Android phone with the correct date and time.
3. create a Sync chain on Desktop.
4. attempt to join the Sync chain on Android (it should FAIL)
5. attempt to join the same Sync chain on iOS (it should FAIL)

example	example	example

Old-style QR codes - PASSED

1. set up a desktop computer with an earlier version of Brave (with the old-style QR codes).
2. set up an Android phone with support for updated QR codes.
3. create a Sync chain on Desktop.
4. attempt to join the Sync chain on Android (it should WORK).
5. reset both browser profiles.
6. change time on desktop computer to January 2nd 2022.
7. change time on Android phone to January 2nd 2022.
8. create a Sync chain on Desktop.
9. attempt to join the Sync chain on Android (it should FAIL).
10. repeat these steps with an iOS phone instead of an Android one.

Desktop & Android - PASSED

example	example	example	example

Desktop & iOS - PASSED

example	example	example	example

[stephendonner]

Going to re-do the macOS section for (and fixed) the testcase Normal expiration test to have the correct 20 and 11-minute values, respectively, for the join-success and join-fail cases.

[stephendonner]

NOTE: Also added another test, Android (Sync-chain creator) -> iOS (joiner), since we have the other creator/joined case already covered under iOS & Android, above.

Normal expiration test

Android & iOS - PASSED

Steps:

1. create a Sync chain on Android and keep it open
2. wait 20 minutes
3. attempt to join Sync chain on iOS (it should WORK)
4. reset Android profile
5. wait 11 minutes (so that it’s > 30 minutes since generating the code)
6. attempt to join Sync chain on iOS (it should FAIL)

example	example	example

[btlechowski]

Verification passed on

Brave	1.33.105 Chromium: 96.0.4664.93 (Official Build) (64-bit)
Revision	17531e0a70b4f8108f2418e8b5117f465077710b-refs/branch-heads/4664@{#1229}
OS	Ubuntu 18.04 LTS

Cross-timezone tests - PASSED

1. set up a desktop on the Los Angeles timezone
2. set up an Android phone on the Auckland (NZ) timezone.
3. create a Sync chain on Desktop
4. attempt to join the Sync chain on Android (it should WORK)
5. reset both browser profiles.
6. change desktop computer to the Auckland (NZ) timezone.
7. change Android phone to the Los Angeles timezone.
8. create Sync chain on Desktop.
9. attempt to join the Sync chain on Android (it should WORK)
10. repeat these steps with two Android phones and no Desktop.
    1. unable to test; only have a single Android test device
11. repeat these steps with a Desktop and an iOS phone
12. repeat these steps with an iOS phone as the Sync chain creator and an Android phone as the Sync chain joiner

Desktop & Android - PASSED

Desktop & iOS - PASSED

Normal expiration test - PASSED

1. create a Sync chain on Desktop and keep it open until Step 6 is done.
2. wait 20 minutes.
3. attempt to join Sync chain on Android (it should WORK).
4. reset Android profile.
5. wait 11 minutes (so that it’s > 30 minutes since generating the code).
6. attempt to join Sync chain on Android (it should FAIL)
7. repeat these steps with two Android phones and no Desktop (NOTE: unable to test; only have a single Android test device)
8. repeat these steps with a Desktop and an iOS phone.
9. repeat these steps with an iOS phone as the Sync chain creator and an Android phone as the Sync chain joiner

Desktop & Android - PASSED

Desktop & iOS - PASSED

Code expiring too far into the future - PASSED

1. set up a desktop computer and change the date to 1 day into the future.
2. set up an Android phone with the correct date and time.
3. create a Sync chain on Desktop.
4. attempt to join the Sync chain on Android (it should FAIL)
5. attempt to join the same Sync chain on iOS (it should FAIL)

Desktop & Android - PASSED

Desktop & iOS - PASSED

Old-style QR codes - PASSED

1. set up a desktop computer with an earlier version of Brave (with the old-style QR codes).
2. set up an Android phone with support for updated QR codes.
3. create a Sync chain on Desktop.
4. attempt to join the Sync chain on Android (it should WORK).
5. reset both browser profiles.
6. change time on desktop computer to January 2nd 2022.
7. change time on Android phone to January 2nd 2022.
8. create a Sync chain on Desktop.
9. attempt to join the Sync chain on Android (it should FAIL).
10. repeat these steps with an iOS phone instead of an Android one.

Desktop & Android - PASSED

Desktop & iOS - PASSED