Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying brave:// results in pasting chrome:// #1973

Closed
kirkins opened this issue Nov 2, 2018 · 3 comments · Fixed by brave/brave-core#4512
Closed

Copying brave:// results in pasting chrome:// #1973

kirkins opened this issue Nov 2, 2018 · 3 comments · Fixed by brave/brave-core#4512

Comments

@kirkins
Copy link

kirkins commented Nov 2, 2018

Description

Copying the url for brave:// in settings results in having chrome:// in clipboard.

Steps to Reproduce

  1. Go to brave://settings/help
  2. Copy the url
  3. paste the url

Actual result:

Expected result:

Paste brave://

Reproduces how often:

All times

Brave version (brave://version info)

Version 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv
Copy link
Contributor

srirambv commented Nov 2, 2018

Dupe of #1616

@srirambv srirambv closed this as completed Nov 2, 2018
@srirambv srirambv added the closed/duplicate Issue has already been reported label Nov 2, 2018
@srirambv srirambv added this to the Dupe / Invalid / Not actionable milestone Nov 2, 2018
@bsclifton bsclifton removed the closed/duplicate Issue has already been reported label Jul 9, 2019
@bsclifton bsclifton removed this from the Dupe / Invalid / Not actionable milestone Jul 9, 2019
@bsclifton bsclifton reopened this Jul 9, 2019
@bsclifton
Copy link
Member

The editing portion of this was addressed when fixing #1616 (with brave/brave-core#1385)

Copy to clipboard not fixed though

@kjozwiak
Copy link
Member

kjozwiak commented Mar 17, 2020

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.7.64 Chromium: 80.0.3987.132 (Official Build) beta (64-bit)
-- | --
Revision | fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS | macOS Version 10.15.3 (Build 19D76)
  • ensured that copying/pasting the following URLs correctly used brave:// instead of chrome://
    • brave://version, brave://rewards, brave://help, brave://wallet, brave://crashes, brave://bookmarks, brave://components, brave://downloads, brave://extensions, brave://flags, brave://gpu, `brave://local-state
  • ensured that the above worked on PB, Tor and Guest windows/instances as well.
  • ensured that chrome:// still resolved to brave:// without any issues

Verification passed on

Brave 1.7.65 Chromium: 80.0.3987.132 (Official Build) dev (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS
  • ensured that copying/pasting the following URLs correctly used brave:// instead of chrome://
    • brave://version, brave://rewards, brave://help, brave://wallet, brave://crashes, brave://bookmarks, brave://components, brave://downloads, brave://extensions, brave://flags, brave://gpu, `brave://local-state
  • ensured that the above worked on PB, Tor and Guest windows/instances as well.
  • ensured that chrome:// still resolved to brave:// without any issues

Verification passed on

Brave 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • ensured that copying/pasting the following URLs correctly used brave:// instead of chrome://
    • brave://version, brave://rewards, brave://help, brave://wallet, brave://crashes, brave://bookmarks, brave://components, brave://downloads, brave://extensions, brave://flags, brave://gpu, `brave://local-state
  • ensured that the above worked on PB, Tor and Guest windows/instances as well.
  • ensured that chrome:// still resolved to brave:// without any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment