Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Hangouts / Google Meet: Screenshare feature is non-functional #1982

Closed
lukemulks opened this issue Nov 4, 2018 · 10 comments · Fixed by brave/brave-core#1227
Closed
Assignees
Labels
needs-investigation A bug not 100% confirmed/fixed priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include site-bug webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@lukemulks
Copy link

Description

Initially experienced this at a talk I was giving last week that used Google Hangouts.

  • On Windows 10 x64, I'm unable to use the screenshare feature in Google Hangouts.
  • I'm also experiencing the same issue from Google Meet (which is the new default for meetings when I attempt to repro from Hangouts).

When I attempt to share my screen, the screenshare button does not function as expected. The button is inactive.

  • I've tested with and w/o Shields enabled, and I observe the same result.
  • I've tested with and w/o camera and microphone access enabled. Same result.

Steps to Reproduce

  1. Go to http://hangouts.google.com
  2. Start a meeting.
  3. Click on the Share Screen (Google Hangouts) or Present Now (Google Meet)

Actual result:

  • On Google Hangouts: Nothing happens. Button for Share Screen is inactive when engaged.
  • On Google Meet: When the Present Now button is clicked, and the screen share option is selected, there is a delay, and the user is eventually presented with an error message. See below.

brave-ghangouts-11032018-error

Expected result:

Screen Share should just work.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 0.55.22 Chromium: 70.0.3538.77 (Official Build) (32-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows
JavaScript V8 7.0.276.32

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? Functions in Chrome as expected.

Additional Information

@bbondy @bsclifton as a heads up - this is a bug that bites in meetings and/or public, and probably would result in a user leaving Brave when they discover it works in Chrome.

@lukemulks lukemulks added needs-investigation A bug not 100% confirmed/fixed webcompat/not-shields-related Sites are breaking because of something other than Shields. site-bug labels Nov 4, 2018
bbondy added a commit that referenced this issue Nov 4, 2018
bbondy added a commit that referenced this issue Nov 4, 2018
@bbondy bbondy added the QA/Yes label Nov 4, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 6, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, 0.61.x - Nightly Jan 8, 2019
@bbondy bbondy modified the milestones: 0.61.x - Nightly, 0.60.x - Dev Jan 8, 2019
@bbondy bbondy modified the milestones: 0.60.x - Dev, 0.59.x - Beta Jan 14, 2019
@CydeSwype
Copy link

I can confirm this is fixed for me on MacOS 10.14.2 with the https://github.com/brave/brave-browser/releases/tag/v0.59.26beta release. Nice job team!

@srirambv
Copy link
Contributor

Verification passed on Linux. More details here brave/brave-core#1252 (review)

@btlechowski
Copy link

btlechowski commented Jan 22, 2019

Verification passed on

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows

Connected Windows 7 and Ubuntu 17.10. Shared screen on Windows 7.

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

Went through several cases with @srirambv & @LaurenWags in brave/brave-core#1252 (review).

@Gary-Armstrong
Copy link

I believe I am having this issue but with version 0.59.35 Chromium: 72.0.3626.81
Might I need to do something on my end, since this was fixed in 0.59.26 ?

@boggle
Copy link

boggle commented Aug 1, 2019

Confirm, still seeing this issue with version 0.66.101 Chromium: 75.0.3770.142 on Mac OS X.
(Both with shields on and off). In general, it would be great if you payed more attention to preconfiguring brave to just work out of the box with commonly used services like google meet, webex and other conferencing systems.

@boggle
Copy link

boggle commented Aug 1, 2019

Just enabled the hangouts extensions, this seems to fix it. Why is it not enabled by default?

@bsclifton
Copy link
Member

@boggle on a fresh install, it does appear to be enabled for me. Have you been using Brave for a while? It's possible that you used it before we changed the default value

@boggle
Copy link

boggle commented Aug 2, 2019

Must have been that; maybe switched 2 month ago or so.

@Gary-Armstrong
Copy link

Tried enabling the Meet toggle. Video worked, they could hear me but I could not hear them. Probably just me, something wonky on my Mac? Just the one switch, yes?

@bsclifton
Copy link
Member

@Gary-Armstrong yup- that one switch should do the trick. It's possible I think to have a different speaker and mic configured (you can check the system settings to confirm) and you may need to restart the browser after enabling

petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-investigation A bug not 100% confirmed/fixed priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include site-bug webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

Successfully merging a pull request may close this issue.