Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchased content from youtube doesn't prompt to install Widevine (Amazon too) #1985

Closed
bbondy opened this issue Nov 4, 2018 · 5 comments · Fixed by brave/brave-core#1033
Closed

Purchased content from youtube doesn't prompt to install Widevine (Amazon too) #1985

bbondy opened this issue Nov 4, 2018 · 5 comments · Fixed by brave/brave-core#1033
Assignees
@iefremov
Labels
OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Milestone
0.59.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Nov 4, 2018 •
edited by karenkliu
Loading

Description

A user from Twitter reports that purchased content doesn't prompt to install Widevine.

Widevine currently only prompts to install based on URL pattern:

https://github.com/brave/brave-core/blob/a57dc16dba02ea52adcca39a5189533e15168752/common/shield_exceptions.cc#L127
But we don't want to prompt for all of youtube.com for Widevine.

So we'd need a content script or some kind of network filter or other detection mechanism.

If Widevine is already installed, it does play.

Steps to Reproduce

I haven't tried these steps yet, but I think they would be:

  1. Go to in a new profile https://www.youtube.com/watch?v=RQn-Pqvnzc8
  2. Purchase it

Actual result:

Video doesn't play
screen shot 2018-11-28 at 12 38 58 pm

Expected result:

It prompts to install Widevine in the URL bar. Clicking the prompt should make the video play.

Reproduces how often:

Always, as long as Widevine is not installed.

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No
@bbondy bbondy added this to the 1.x Backlog milestone Nov 4, 2018
@srirambv
Copy link
Contributor

srirambv commented Nov 5, 2018 •
edited
Loading

There is also an issue on Spotify & Amazon.de where users don't get prompt for Widevine to play prime videos, but works on primevideo.com

https://community.brave.com/t/how-do-i-enable-widevine-in-beta-when-the-browser-does-not-prompt/36739/2?u=sriram

@bbondy bbondy changed the title Purchased content from youtube doesn't prompt to install Widevine Purchased content from youtube doesn't prompt to install Widevine (Amazon too) Nov 6, 2018
@bbondy bbondy mentioned this issue Nov 6, 2018
Merged
9 tasks
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Nov 6, 2018
@iefremov iefremov self-assigned this Nov 19, 2018
@eljuno
Copy link

eljuno commented Nov 22, 2018

+1 from Community for amazon.de https://community.brave.com/t/are-there-any-solutions-for-widevinecdm-problem/37966?u=eljuno

@karenkliu
Copy link

+1 here too

@iefremov iefremov mentioned this issue Dec 6, 2018
Merged
18 tasks
iefremov pushed a commit to brave/brave-core that referenced this issue Dec 12, 2018
Issue 1985: Properly show the widevine absence prompt.
6c5c8f5 
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.
bbondy pushed a commit to brave/brave-core that referenced this issue Dec 12, 2018
@bbondy
Issue 1985: Properly show the widevine absence prompt.
c125186 
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.
@bbondy bbondy modified the milestones: 1.x Backlog, 0.59.x - Beta Dec 14, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Jan 23, 2019 •
edited by btlechowski
Loading

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X
  • ensured that I received the Widevine notification on Netflix, YouTube and Amazon Prime Video

Amazon Prime Video -- PASSED

screen shot 2019-01-23 at 4 43 32 pm

Netflix -- PASSED

screen shot 2019-01-23 at 5 09 07 pm

YouTube -- PASSED

screen shot 2019-01-23 at 5 12 03 pm

Verification passed on

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows

[PASS] Amazon Prime Video
image

[PASS] Netflix
image

[PASS] youtube
image

@srirambv
Copy link
Contributor

Marking issue as Windows/macOS only as Linux doesn't support Widevine (yet)

This was referenced Jan 29, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iefremov iefremov

Labels
OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Issue 1985: Properly show the widevine absence prompt. brave/brave-core
8 participants
@bbondy @karenkliu @kjozwiak @iefremov @rebron @srirambv @eljuno @btlechowski