Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to scroll Tab groups bar icons on swipe #19902

Closed
samartnik opened this issue Dec 3, 2021 · 2 comments · Fixed by brave/brave-core#11939
Closed

Add ability to scroll Tab groups bar icons on swipe #19902

samartnik opened this issue Dec 3, 2021 · 2 comments · Fixed by brave/brave-core#11939

Comments

@samartnik
Copy link
Contributor

samartnik commented Dec 3, 2021

Description

VTR-L29.2021-12-03.21-38-05.mp4

Steps to reproduce

  1. Add enough tabs so that icons in Tab groups bar go beyond sceen.
  2. Try swiping on Tab groups bar's icons.
  3. Instead of scrolling icons it scrolls through tabs.

Actual result

Instead of scrolling icons it scrolls through tabs.

Expected result

It should scroll icons like it's done in Chromium.

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Dec 3, 2021
@samartnik samartnik changed the title Tab groups bar is not scrolled on swipe Add ability to scroll Tab groups bar on swipe Jan 20, 2022
@samartnik samartnik changed the title Add ability to scroll Tab groups bar on swipe Add ability to scroll Tab groups bar icons on swipe Jan 20, 2022
@samartnik samartnik self-assigned this Jan 20, 2022
@samartnik
Copy link
Contributor Author

For test plan follow STR and make sure on step 3 we have expected result. In addition double check that swiping on bottom toolbar itself scrolls through the tabs.

@srirambv
Copy link
Contributor

Verification passed on Oppo reno 5 with Android 12 running 1.36.104 x64 build

  • Verified steps from issue description
  • Verified able to scroll through tabs in tab group which are out of view by both bottom bar swipe and URL bar swipe
Bottom bar swipe URL bar swipe
19902-Bottom.bar.Swipe.mp4
19902-URL.bar.Swipe.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants